forge-ext / forge

Forge - Tiling and Window Manager for Gnome-Shell
GNU General Public License v3.0
840 stars 41 forks source link

bug: Tiled outline/hint wrong size for window #164

Open Cushee-Foofee opened 1 year ago

Cushee-Foofee commented 1 year ago

Describe the bug/issue The outline for tiled mode is smaller than the window, resulting in the outline covering part of the window.

To Reproduce Steps to reproduce the behavior:

  1. Get 4 windows on 1 1920 * 1080 resolution monitor.
  2. Arrange then as a 2x2 grid.
  3. Changing focus over them may show the bug.
  4. You may need to move some of the windows around.

Expected behavior The outline should just follow the exact outline.

Screenshots or journal logs GithubWillNotTakeMyImage?

Version Information

  1. Distro and version: Fedora 37, with Kernel 6.0.9-300
  2. Forge version or from source (branch or commit): Forge version is 43.1-60, obtained from the gnome extensions website.
  3. Gnome-shell version (gnome-shell --version): Neofetch shows Shell: Bash 5.2.9

Monitor Setup

  1. 2 x 1920 X 1080p
  2. Dual monitor side by side horizontal wise?

Additional context Would be cool if I could turn the hint tiling preview thingy stuff to 0, so I wouldn't have to see the edges, which also have issues of bleeding onto the other monitor, and hiding the scroll bar (Or at least making it harder to see my scroll bar).

jmmaranan commented 1 year ago

Hi @Cushee-Foofee assuming you are on Wayland?

jmmaranan commented 1 year ago

Would be cool if I could turn the hint tiling preview thingy stuff to 0, so I wouldn't have to see the edges, which also have issues of bleeding onto the other monitor, and hiding the scroll bar (Or at least making it harder to see my scroll bar

The toggle for preview hint showing is doable.

Cushee-Foofee commented 1 year ago

First off, sorry I am new to Github, not sure if this comment will close this issue, but Github is saying this comment will close this bug report sadly.

Yes, I should be on Wayland.

Also, are you saying there's an option to remove the preview hint and I missed it? Or that it's not implemented? Sorry if I missed it.

I also forgot to add that I am using an Nvidia GPU and have had serious issues on Pop!_os as well with their auto tiling, so there's a chance some bugs are due to my hardware.

wroyca commented 1 year ago

Would be cool if I could turn the hint tiling preview thingy stuff to 0, so I wouldn't have to see the edges, which also have issues of bleeding onto the other monitor, and hiding the scroll bar (Or at least making it harder to see my scroll bar

The toggle for preview hint showing is doable.

I'm just dropping by quietly to say that I actually set each "hint" (border) to 0 and black because I don't like them overall so that would be really nice :)

Cushee-Foofee commented 1 year ago

Would be cool if I could turn the hint tiling preview thingy stuff to 0, so I wouldn't have to see the edges, which also have issues of bleeding onto the other monitor, and hiding the scroll bar (Or at least making it harder to see my scroll bar

The toggle for preview hint showing is doable.

I'm just dropping by quietly to say that I actually set each "hint" (border) to 0 and black because I don't like them overall so that would be really nice :)

How? Whenever I set the border size to 0, it automatically goes to 1!

jmmaranan commented 1 year ago

You can remove the border hint by pressing Super + X. There is small bug on the split border. @Cushee-Foofee I meant that adding a toggle for the rest of the hints,like when dragging/dropping can be implemented.

Cushee-Foofee commented 1 year ago

You can remove the border hint by pressing Super + X. There is small bug on the split border. @Cushee-Foofee I meant that adding a toggle for the rest of the hints,like when dragging/dropping can be implemented.

Oh, I forgot about looking at the shortcuts. But yeah, having a toggle, or at least the ability of just doing 0 width for the hints would be nice.

Also, has anyone mentioned the bug where moving windows across a monitor may result in the sizing being wrong? Because multiple times at random, it seems that moving a window may or may not have it take up the proper size. In other words, sometimes it seems that the ratio a window takes is like, 1700 x 800, instead of my 1920 X 1080.

Although Pop!_os had that issue a few times for me as well, but not as often as Forge on Fedora.

wroyca commented 1 year ago

Would be cool if I could turn the hint tiling preview thingy stuff to 0, so I wouldn't have to see the edges, which also have issues of bleeding onto the other monitor, and hiding the scroll bar (Or at least making it harder to see my scroll bar

The toggle for preview hint showing is doable.

I'm just dropping by quietly to say that I actually set each "hint" (border) to 0 and black because I don't like them overall so that would be really nice :)

How? Whenever I set the border size to 0, it automatically goes to 1!

My bad - I meant 1*

jmmaranan commented 1 year ago

Hi everyone, at the time of this reply, I have fixed the split-border still showing up when you toggle the border-hint. https://github.com/jmmaranan/forge/commit/4a8b9394dd4507aa85dfeca708842e93609f8098

For the preview-hint, I think @Cushee-Foofee - you meant the drag/drop hint, this has been added as workaround for the random issues in #175, and you can toggle it off from the preferences (<Super> + . to open up prefs)

jmmaranan commented 1 year ago

Hi @Cushee-Foofee is this still happening?

Cushee-Foofee commented 1 year ago

Hi @Cushee-Foofee is this still happening?

Screenshot from 2023-04-30 12-48-14

Sorry, it still keeps happening. I haven't noticed though since I just turn the highlight off regardless.

I just upgraded to Fedora 38, still workstation and Wayland. Kernel: 6.2.13-600.fc38.x86_64. Shell: 5.2.15 DE: Gnome 44.1 Forge extension version: 44.1-67

Everything else should be the same.

This time I did have to manually move the windows. I also noticed a few more bugs, so I will post a new post for those as I assume that's best practice?

jmmaranan commented 1 year ago

Hey @Cushee-Foofee for this, please also post a screencast if you can. Thanks!

Cushee-Foofee commented 1 year ago

Hey @Cushee-Foofee for this, please also post a screencast if you can. Thanks!

Screencast from 2023-04-30 17-48-18.webm

Oh and here's a bonus:

Screenshot from 2023-04-30 17-49-07

Right after deleting one of the windows, the other window had half of it just missing. When clicking on the window it regains the other half. Kinda weird.