search

forge-ext / forge

Forge - Tiling and Window Manager for Gnome-Shell
GNU General Public License v3.0
894 stars 48 forks source link

feat: respect current gtk theme #179

Closed meppu closed 1 year ago

meppu commented 1 year ago

Is your feature request related to a problem? Please describe. So looks like forge doesn't care about gtk themes and instead allows users to change colors, but there are some things that we can't change (at least not in appearence tab) like changing tab background, selected tab foreground etc...

Describe the solution you'd like An option in appearance tab allows us to enable/disable gtk theme like chrome does. So we don't need to manually configure all of them.

Describe alternatives you've considered More color settings for tabs etc...

Additional context Very nice extension for me since PaperWM doesn't work on GNOME 43 (it is experimental and broken) this works really well. good job!

jmmaranan commented 1 year ago

Hi @cart96 - so that I understand, you have a gtk theme and you wanted Forge to follow that same theme? Or make them seamless with your theme?

jmmaranan commented 1 year ago

In the case of stock Gnome, I suppose we want to have Forge respect the default Adwaita theme?

meppu commented 1 year ago

Hi @cart96 - so that I understand, you have a gtk theme and you wanted Forge to follow that same theme? Or make them seamless with your theme?

Yeah it would be very nice if they were an option that makes forge to use same theme as my gtk4/3 theme. So i think yeah it needs to use default theme i think

meppu commented 1 year ago

I don't really know about how gnome extensions works so i am unable to say if forge tabs uses adwaita or not, but my theme also includes adwaita

meppu commented 1 year ago

In the case of stock Gnome, I suppose we want to have Forge respect the default Adwaita theme?

yes exactly!

jmmaranan commented 1 year ago

The Forge styles for tabs, etc just denotes what mode they are on or which window is active. Or what layout you are going to get into when you drag and drop over another window. Since Gnome does not have these, or else we will not have this extension. If we switch to the default theme, Forge will not have the ability to customize it. Forge has its own stylesheet and not modifying the current theme.

meppu commented 1 year ago

I understand, thanks for the reply! I am closing the issue then.

Again, good job 👏

jmmaranan commented 1 year ago

Thanks. We can probably use the styles from an existing effect. The default snap left and snap right has a bluish effect. The active hint will use the style from the highlight of the workspace during an overview. Everything else uses the bluish hint from snaps. And then the colors can be derived from that blue or whatever the theme color is set for that effect. E.g. 50%, 40% etc.