search

forgecrafted / rulerz

[Looking for maintainer] A simple Atom package to mark your cursor position with a ruler.
MIT License
6 stars 7 forks source link

Config removal #14

Closed n3dst4 closed 8 years ago

n3dst4 commented 8 years ago

Hello, I hope you don't mind unsolicited pull requests, especially ones that are basically a big deletion?

I started off wanting to change the color of rulerz's ruler lines, which entailed adding a stylesheet rule. I then realised we could potentially set the width there too, but that was blocked by the "width" config overwriting it. So I forked and removed the width config. It seems to me that using the stylesheet is the Atom-y way of doing this kind of thing.

Then I realised the "enable" config option was surplus to requirement since atom has its own enable/disable in the package manager now. So I kinda deleted all the config subscriptions and replaced them with a note in the README.

cmtonkinson commented 8 years ago

Deleted code is the best kind of code; I'm only jealous I didn't get to do it ;-)

In truth, we got fatigued tracking all the API changes leading up to the 1.0 and we started ignoring them as long as the plugin didn't completely blow up, so this is a very welcome PR. I'm looking at it now.