Closed n3dst4 closed 7 years ago
Would you mind sharing a screenshot including the ruler line for comparison? Which syntax theme are you using? Here's mine; you can hardly make out the line (which is just before the c
in @text-color-subtle
).
The original design intent was to have the ruler line match the styles of the line highlight, which is why we chose solid @text-color-subtle
. I could be convinced otherwise, but I think your other PR exposes this setting simply enough for most cases.
Oh interesting. I'm using the default One Dark theme and the ruler is quite stark by default
Same using One Light:
And here it is with the dashed/faded style:
Perhaps we could compromise? I quite like the dashed effect since it's visually distinct from indent guides (for those that have them) but crank the opacity up to, say, 60%?
I think the root problem here is that line-highlight styles have diverged from what they were (and how they're drawn) when I first mimicked them for the ruler. I'll play with that (maybe later today) and push an update to get back to the baseline; then if the ruler is still too strong — or isn't distinguished enough from line guides, et cetera — we can play with it some more.
My preference is to match line-highlight styles exactly, but you aren't the first person to suggest dashing so I'm not staunchly opposed to it. Besides - #14 makes it easier than ever to override the defaults :+1:
had some free time just now so i updated it to the use the syntax variables for the cursor line, but they seem to be not as well defined as the ui variables so it breaks when using an older theme (like Atom Dark and Atom Light).
This just tweaks the default rulerz stylesheet so that the ruler line is less visually intrusive.