forgecrafted / rulerz

[Looking for maintainer] A simple Atom package to mark your cursor position with a ruler.
MIT License
6 stars 7 forks source link

Deprecated selector in `rulerz/styles/cursor-ruler.less` #21

Closed carolfalardeau closed 7 years ago

carolfalardeau commented 7 years ago

In rulerz/styles/cursor-ruler.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

sergeysova commented 7 years ago

@BattleBrisket @cmtonkinson

BattleBrisket commented 7 years ago

@LestaD @cmtonkinson is the driver on this one, and has been busy with his wife welcoming their second child to the world earlier this week.

Fortunately, this is a volunteer effort, and open source contributions look great on a resume - https://github.com/forgecrafted/rulerz#contributing

danielbayley commented 7 years ago

PR #22 already fixes this… it just needs merging!