forgottenlabs / wklejorg

wklej.org
MIT License
8 stars 3 forks source link

can't reply to a pastie #21

Closed Nowaker closed 10 years ago

Nowaker commented 10 years ago

I want to reply to this pastie: https://wklej.stratushost.eu/hash/b71abc4e1a8/ I get 404: https://wklej.stratushost.eu/hash/b71abc4e1a8/re/?s=1

Nothing really interesting in the log, just a 404:

Dec 29 21:13:42 apps.stratushost.eu start.sh[8771]: [29/Dec/2013 21:13:42] "GET /hash/b71abc4e1a8/re/?s=1 HTTP/1.1" 404 1225`

Do you have any idea?

artcz commented 10 years ago

That's because replying to private pasties is blocked. I don't remember the initial idea behind it, but I think it's due to the fact that we didn't want to post URLs to private pastes anywhere in the system. And you would have "This is a response for ........" on top of your new paste.

Nowaker commented 10 years ago

I see, it's reasonable. We need to remove the reply link from the private pastie then.

Nowaker commented 10 years ago

Or maybe - instead of disabling this feature for private pasties - force the replies to be private as well?

artcz commented 10 years ago

I thought about it before, and it seems reasonable. Although there is one problem with it - let's say I add a pastie A (which is private), then you add response B to it, and then somebody who got your link will add pastie C and then share it on some forum or whatever place on the Internet. Then all pasties – A,B,C are exposed for everyone on the internet including webscrapers. Also – if somebody add pastie Z as a respone to A, it will be available as well.

Nowaker commented 10 years ago

Then all pasties – A,B,C are exposed for everyone on the internet including webscrapers

How? #59 is a response to #58, but there isn't any link to #58, so it's not exposed.

Nowaker commented 10 years ago

Regarding webscrapers, we should add no-index to all private pasties. EDIT: ok, there is already robots.txt.

Nowaker commented 10 years ago

These translation messages suggest there used to be a feature you are mentioning.

#: templates/wklej/single.dhtml:19
msgid "To odpowiedź na wklejkę"
msgstr "It is response for"

However it doesn't exist now, so it's safe to just enable replies to private pasties.

artcz commented 10 years ago

This is already merged with #25