deprecation of rbac.authorization.k8s.io/v1beta1

foriequal0 / pod-graceful-drain

You don't need `lifecycle: { preStop: { exec: { command: ["sleep", "30"] } } }`

Apache License 2.0

246 stars 16 forks source link

deprecation of rbac.authorization.k8s.io/v1beta1 #22

Closed ajaykumarmandapati closed 3 years ago

ajaykumarmandapati commented 3 years ago

We would need to upgrade our EKS version to 1.17 from 1.16 which deprecates rbac.authorization.k8s.io/v1beta1 , we found relevances to it in your code but could not completely understand if they are actively being used in the project. Could you confirm if these would be upgraded in the near future since we might move to EKS 1.21 in the coming months.

foriequal0 commented 3 years ago

The file is generated by controller-gen. I expect it to be naturally migrated to the newer version if I upgrade controller-gen. I also uses EKS so it'll be upgraded someday.

ajaykumarmandapati commented 3 years ago

Thanks for your answer, I've raised a PR for the same - https://github.com/foriequal0/pod-graceful-drain/pull/23