Use `rbac.authorization.k8s.io/v1` for metric-reader ClusterRole

foriequal0 / pod-graceful-drain

You don't need `lifecycle: { preStop: { exec: { command: ["sleep", "30"] } } }`

Apache License 2.0

246 stars 16 forks source link

Use `rbac.authorization.k8s.io/v1` for metric-reader ClusterRole #23

Closed ajaykumarmandapati closed 3 years ago

ajaykumarmandapati commented 3 years ago

We would need to upgrade our EKS version to 1.17 from 1.16 which deprecates rbac.authorization.k8s.io/v1beta1 , we found relevances to it in your code but could not completely understand if they are actively being used in the project.

Hey, I made the relevant changes in the API and then ran make generate. Thanks!

foriequal0 commented 3 years ago

Thanks. Can you do it again for go.sum too? I want you to rebase the branch so it contain only 1 commit.

foriequal0 commented 3 years ago

Thank you!

ajaykumarmandapati commented 3 years ago

Hello! @foriequal0 Could you let us know the release mechanism for this version ? we would like to upgrade our PGD to this version.

foriequal0 commented 3 years ago

I only manage versions of binary, and Helm template. I don't manage version of kustomize manifests under config/. You just download kustomize manifests to your project and deploy them.