search

forio / contour

Apache License 2.0
120 stars 21 forks source link

Trendline animation specific #219

Closed senluchen2015 closed 8 years ago

senluchen2015 commented 9 years ago

add options to disable trendline animation depending on the option: chart: { trendline: { animations: duration } } chart: { trendline: { animations: enable } }

drosen0 commented 9 years ago

Here are some issues with this pull request in its current state.

  1. The lines you edited are in the distribution build of contour. You'd want to make your changes to the source of trend-line.js.
  2. The constructor function will fail if options.chart.trendline (or options.chart.trendline.animations) is undefined, and I don't believe it's defined by default.
  3. Previously the trend-line would not animate if options.chart.animations is false, and this is a change in functionality.
drosen0 commented 8 years ago

@senluchen2015, I'm going to close this PR as it can't be merged in its current form. If/when you address the issues above, please either re-open this PR or create a new one.