search

forio / contour

Apache License 2.0
120 stars 21 forks source link

Contour gallery doesn't work with ad-blockers turned on #234

Closed narenranjit closed 8 years ago

narenranjit commented 8 years ago

http://forio.com/contour/gallery.html#/chart/bar/bar-styled for e.g.,

We're using fancy google analytics custom events, and not accounting for the possibility that google analytics may be blocked entirely.

We're not actually analyzing google analytics in that level of detail anyway, so may be simpler just to remove if wrapping everything in a if(!analytics)return is too much work.

mmrj commented 8 years ago

closing as duplicate of https://issues.forio.com/browse/FNM-112

(we're using GitHub for Contour issues, but if it's specific to the Contour gallery/website as opposed to Contour library/docs, that goes in the jira project. sorry for the confusion.)