Closed narenranjit closed 6 years ago
https://github.com/forio/contour/blob/3dd5f7ddfe42d74b82194fa3d176e735c8a952fb/src/scripts/visualizations/line.js#L84-L86 if markers were initially enabled, but are later disabled they need to be removed. Maybe pass enable flag to renderMarkers and let it decide whether to add or remove.
There are likely a few more places where assumptions like this are made; now that we can update options we should audit code to check.
cc @jaimedp
narenranjit
commented
6 years ago narenranjit
commented
6 years ago
https://github.com/forio/contour/blob/3dd5f7ddfe42d74b82194fa3d176e735c8a952fb/src/scripts/visualizations/line.js#L84-L86 if markers were initially enabled, but are later disabled they need to be removed. Maybe pass enable flag to renderMarkers and let it decide whether to add or remove.
There are likely a few more places where assumptions like this are made; now that we can update options we should audit code to check.