[Feature Request] Filter By Author/Commit Message/SHA/Etc & Old Search UI

[antom]

Fork used to have a search input at the top-right of the app. Now you have to access this by clicking a button in the sidebar to bring up the search panel in the sidebar. This adds a bit of extra friction into performing a search & would be great to provide the option to bring back the old search input at the top-right of the app.

Also, the old search UI would let you search commits by a given criteria (author/SHA/message/etc) & would properly filter the main commit listings. The current search UI lists them in the sidebar & adds a subtle highlight in the main commit listings.

This isn't always as helpful for a quick overview of commits by search criteria - it would be nice productive feature to have the option to bring back the old method of showing search listings as an additional filtering method for the main commit tree listing.

[DanPristupov]

Fork used to have a search input at the top-right of the app. Now you have to access this by clicking a button in the sidebar to bring up the search panel in the sidebar. This adds a bit of extra friction into performing a search

It used to be an one-click action (a click on the toolbar item), it's still an one-click action (a click on the sidebar item).

the old search UI would let you search commits by a given criteria (author/SHA/message/etc)

The new search also allows this

The current search UI lists them in the sidebar & adds a subtle highlight in the main commit listings.

The highlighting remained the same

would properly filter the main commit listings

The old search never filtered the commits (it only highlighted them, same as now) and this is the reason why we introduced the new search.

[DanPristupov]

However I do understand what you mean and it makes sense.

(thinking out loud) There are two different features: advanced search and context search. We have replaced context search with advanced search, but we probably need both of them.

• Context search (⌘F) for 'jump-to' kind of actions
• Advanced search (⌘⇧F) to search complex cases when we need to see all matches.

[antom]

It used to be an one-click action (a click on the toolbar item), it's still an one-click action (a click on the sidebar item).

I've just pulled this image from Fork's Website:

There's a search input clearly visible to the top-right part of the app's UI - not a toolbar item. This disappeared when the new search was launched.

From a usability perspective it's a fairly common place to have the search input at the top-right on OSX. Even after so many subsequent updates to Fork, I still instinctively look to the top-right of the app to perform a search & have to remember that it's been moved.

The old search never filtered the commits (it only highlighted them, same as now) and this is the reason why we introduced the new search.

I'm pretty sure that it did used to hide any non-matching commits, as I often used it for checking what I'd been working on when sorting out timesheets & other business admin. It was really handy to just get a list of my commits with the usual details from the main commit tree listing - the abbreviated results list in the sidebar isn't as helpful in such cases (particularly the lack of times).

I'm not saying that the new search is inferior or anything (it's actually great for jumping to a particular commit fairly quickly), but there were definitely a few things about the old method that worked well in terms of filtering the main commit tree panel that would be nice to have available again. Perhaps it's a case of re-classing this as a filtering method rather than search?

Also, ⌘⇧F is the shortcut for Fetch, so would likely need a different keyboard shortcut.

Thanks for the response & keep up the great work!