search

fork-dev / Tracker

Bug and issue tracker for Fork for Mac
509 stars 12 forks source link

Incorrect $PATH variable in pre-commit exec environment #1227

Open SachinShekhar opened 3 years ago

SachinShekhar commented 3 years ago

MacOS 11.1 update broke Fork's exec environment.

echo $PATH in pre-commit hook displays different outputs in Fork & terminals.

Fork: /usr/local/Cellar/git/2.28.0/libexec/git-core:/Applications/Fork.app/Contents/Resources/git-instance/git-lfs:/Applications/Fork.app/Contents/Resources/gitflow-avh:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin

Any Terminal: /Users/Sachin/.avn/bin:/Users/Sachin/.nvm/versions/node/v14.12.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/MacGPG2/bin:/Library/Apple/usr/bin

So, naturally, lots of commands fail to run with Command not found error.

niklasravnsborg commented 2 weeks ago

Was thinking about this problem for last few days, because my Fork instance doesn't find my custom installed gpg binary. I tried setting my global user path with sudo launchctl config user path "/additional/bin:/usr/bin:/bin" but it didn't work on Sequoia.

Wouldn't it be best if Fork would (give the option to) execute all commands (like git, gpg, ssh, precommit hooks, etc.) using the users zsh with zsh -c to ensure all correct environment variables and binaries are available?