search

fork-dev / Tracker

Bug and issue tracker for Fork for Mac
509 stars 12 forks source link

[Feature request] WebP support #1553

Open melbic opened 2 years ago

melbic commented 2 years ago

Would it be possible to add WebP support to get a preview inside Fork? That would be super great for Android developers.

spartanatreyu commented 2 years ago

WebP support would be great for web developers too!

StefanoCecere commented 1 year ago

i've migrated all webites to WebP images.. and now i feel that Fork should support these images... pleassee

StefanoCecere commented 1 year ago

workspaces are great! but please rememeber webps :=) BTW GitHub desktop has a top notch image diff

jarmo commented 1 year ago

Also missing webp preview.

DanPristupov commented 1 year ago

I don't want to include a c-library in Fork.

Here is one of the reasons: https://news.ycombinator.com/item?id=37478403

[$NA][1479274] Critical CVE-2023-4863: Heap buffer overflow in WebP. Reported by Apple Security Engineering and Architecture (SEAR) and The Citizen Lab at The University of Torontoʼs Munk School on 2023-09-06

spartanatreyu commented 1 year ago

Hmm yes, looking around it's hard to find a safe webp library.

I can see there's a rust image crate that has webp decoding without relying on a c dependency: https://github.com/image-rs/image (it does for encoding, but that's not something fork would be doing).

It has a tiny number of unsafe keywords, that some pull requests are working on removing. But according to the issues, they're lacking some dedicated maintainers for webp.

Here is one of the reasons: https://news.ycombinator.com/item?id=37478403

Maybe this event will be the much needed kick-in-the-arse for some safer codec libraries.