fork-dev / Tracker

Bug and issue tracker for Fork for Mac
509 stars 12 forks source link

Show all User IDs in the GPG keys list #1801

Closed DominikPalo closed 1 year ago

DominikPalo commented 1 year ago

I'd like to point out the issue I'm having with the Fork client on macOS. I use a GPG key containing multiple User IDs (emails). But as you can see on the attached screenshots, the GPG keys list in Fork shows only the last User ID. It is a bit confusing for me because I use multiple GPG keys - some of them just with a single User ID. It would be much better to show all User IDs/emails inside the <> bracket for a particular GPG key (similar to how GitHub works - see that last screenshot) or show the main email address assigned to the Key (email from the "Key" tab). Displaying only the latest email doesn't really make sense, as it can change anytime (sometimes I'm adding/removing user IDs from my GPG key)

image

image

image image

DanPristupov commented 1 year ago

Hi.

I'm not a very big expert in gpg signing and trying to figure out your issue.

It would be much better to show all User IDs/emails inside the <> bracket for a particular GPG key

So, is the proposal to remove the identity name and list all identity emails in the dropdown item title?

Instead of: 09976F5F Dominik Paľo <dominik@palo.sk>

Make it: 09976F5F <dominik@palo.sk>, <dominik@slido.com>, <dominik@cisco.com>

DominikPalo commented 1 year ago

@DanPristupov I'd probably include the full name from the key signature and list all email addresses from user IDs. So in my case, it would be: 09976F5F Dominik Paľo <dominik@palo.sk>, <dominik@slido.com>, <dominik@cisco.com>

But, I have an idea - what about listing all GPG keys in a List component (instead of using a simple/text dropdown)? Something like this:

image
DanPristupov commented 1 year ago

I think it's wrong to assume that the name of the identity is the same.