fork-dev / Tracker

Bug and issue tracker for Fork for Mac
509 stars 12 forks source link

[Bug] Amend commit is incorrectly selected after aborting an Interactive rebase with Edit #1917

Closed gentique closed 1 year ago

gentique commented 1 year ago

Fork Version 2.29.2

Interactively rebase and select edit on a commit

Screenshot 2023-06-16 at 12 18 52 AM

Abort the rebase

Screenshot 2023-06-16 at 12 19 11 AM

Amend option is selected incorrectly

Screenshot 2023-06-16 at 12 19 20 AM
DanPristupov commented 1 year ago

I can't reproduce that. The Amend button becomes enabled only when you start IR.

gentique commented 1 year ago

I can't reproduce that. The Amend button becomes enabled only when you start IR.

(If IR = Interactive Rebase) That is what I am doing in the described steps, starting an interactive rebase where you are doing an Edit on a commit, then aborting the rebase.

DanPristupov commented 1 year ago

Is Amend unchecked before you start IR (interactive rebase) window?

gentique commented 1 year ago

I've attached a screen recording showcasing my steps:

https://github.com/fork-dev/Tracker/assets/15278390/bc36986c-2864-4053-8c86-76ff16162775

DanPristupov commented 1 year ago

I see, thanks.

DanPristupov commented 1 year ago

We fixed the problem in Fork 2.30

gentique commented 1 year ago

Amazing work Dan!