search

fork-dev / Tracker

Bug and issue tracker for Fork for Mac
505 stars 12 forks source link

[macOS] Fork 2.45: Abnormal Initial Window Size and Position #2182

Open honood opened 1 month ago

honood commented 1 month ago

After upgrading to version 2.45, I noticed that when launching Fork via the command line, the window opens with a very small size, positioned towards the bottom-left of the screen, with part of it obscured by the screen’s bottom edge. Please see the screenshot below for reference.

image
bysameng commented 1 month ago

Same problem here. Happens even without launching Fork via the command line.

Reproduction steps:

  1. Open Fork normally
  2. Close the Fork window (Command-W)
  3. Click Fork in the Dock
  4. Fork window will open positioned in the lower left corner and tiny.

I'm on M3 Sonoma 14.6.1

DanPristupov commented 1 month ago

Thank you for reporting the regression. I need think how to fix this. We will release a hotfix update during the day.

DanPristupov commented 1 month ago

I made a new build. Can you try if everything works properly, please? https://cdn.fork.dev/mac/Fork-2.45.1.dmg

honood commented 1 month ago

Dan, Thanks for your work. I just updated to version 2.45.1 through the app’s check for updates. Unfortunately, I’m still able to reproduce the case locally.

For clarity, my reproduction steps are as follows:

  1. Launch Fork and open multiple local Git repositories in separate tabs;
  2. Set Fork to full-screen mode;
  3. In iTerm2.app, execute the command fork <path/to/git/repo> (I’ve already tried uninstalling and reinstalling the fork CLI through the Settings panel);

  4. The newly opened Fork window exhibits the behavior described in the issue.

Additionally, I encountered a consistent crash, though I’m not sure if it’s related to this issue. The reproduction steps are as follows:

  1. Launch Fork and open multiple Git repositories in separate tabs.
  2. Set Fork to full-screen mode.
  3. While in full-screen mode, quit Fork.
  4. In iTerm2.app, execute the command fork <path/to/git/repo>. Then the Fork window briefly appears and then immediately closes.

Crash log:

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               Fork [76558]
Path:                  /Applications/Fork.app/Contents/MacOS/Fork
Identifier:            com.DanPristupov.Fork
Version:               2.45.1 (2.45.1)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               502

Date/Time:             2024-08-19 10:43:32.6084 +0800
OS Version:            macOS 14.6.1 (23G93)
Report Version:        12
Anonymous UUID:        F71089CD-37DB-2102-CA41-034FD2BB84E2

Sleep/Wake UUID:       82A2F945-FBF1-44BD-9517-7B1F790A7EFE

Time Awake Since Boot: 550000 seconds
Time Since Wake:       2081 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Application Specific Information:
abort() called

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib                 0x1858315f0 __pthread_kill + 8
1   libsystem_pthread.dylib                0x185869c20 pthread_kill + 288
2   libsystem_c.dylib                      0x185776a30 abort + 180
3   Fork                                   0x104a6e180 0x104570000 + 5235072
4   Fork                                   0x104a6bdf0 0x104570000 + 5225968
5   CoreFoundation                         0x185a63024 __handleUncaughtException + 800
6   libobjc.A.dylib                        0x1854abbe4 _objc_terminate() + 132
7   Fork                                   0x104a0d1d8 0x104570000 + 4837848
8   libc++abi.dylib                        0x1858200cc std::__terminate(void (*)()) + 16
9   libc++abi.dylib                        0x185820070 std::terminate() + 108
10  libdispatch.dylib                      0x1856b93fc _dispatch_client_callout + 40
11  libdispatch.dylib                      0x1856c7bb8 _dispatch_main_queue_drain + 988
12  libdispatch.dylib                      0x1856c77cc _dispatch_main_queue_callback_4CF + 44
13  CoreFoundation                         0x18598aad4 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16
14  CoreFoundation                         0x185948258 __CFRunLoopRun + 1996
15  CoreFoundation                         0x185947434 CFRunLoopRunSpecific + 608
16  HIToolbox                              0x1900f119c RunCurrentEventLoopInMode + 292
17  HIToolbox                              0x1900f0fd8 ReceiveNextEventCommon + 648
18  HIToolbox                              0x1900f0d30 _BlockUntilNextEventMatchingListInModeWithFilter + 76
19  AppKit                                 0x1891a6cc8 _DPSNextEvent + 660
20  AppKit                                 0x18999d4d0 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 700
21  AppKit                                 0x189199ffc -[NSApplication run] + 476
22  AppKit                                 0x189171240 NSApplicationMain + 880
23  Fork                                   0x104756a78 0x104570000 + 1993336
24  dyld                                   0x1854df154 start + 2476

Thread 1:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 2:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 3:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 4:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 5:
0   libsystem_kernel.dylib                 0x185828df4 mach_msg2_trap + 8
1   libsystem_kernel.dylib                 0x18583b5e4 mach_msg2_internal + 80
2   libsystem_kernel.dylib                 0x1858319c4 mach_msg_overwrite + 476
3   libsystem_kernel.dylib                 0x185829178 mach_msg + 24
4   Fork                                   0x104a663bc 0x104570000 + 5202876
5   libsystem_pthread.dylib                0x185869f94 _pthread_start + 136
6   libsystem_pthread.dylib                0x185864d34 thread_start + 8

Thread 6:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 7:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 8:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 9:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 10:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 11:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 12:
0   libsystem_pthread.dylib                0x185864d20 start_wqthread + 0

Thread 13:: com.apple.NSEventThread
0   libsystem_kernel.dylib                 0x185828df4 mach_msg2_trap + 8
1   libsystem_kernel.dylib                 0x18583b5e4 mach_msg2_internal + 80
2   libsystem_kernel.dylib                 0x1858319c4 mach_msg_overwrite + 476
3   libsystem_kernel.dylib                 0x185829178 mach_msg + 24
4   CoreFoundation                         0x185949680 __CFRunLoopServiceMachPort + 160
5   CoreFoundation                         0x185947f44 __CFRunLoopRun + 1208
6   CoreFoundation                         0x185947434 CFRunLoopRunSpecific + 608
7   AppKit                                 0x1892d1280 _NSEventThread + 144
8   libsystem_pthread.dylib                0x185869f94 _pthread_start + 136
9   libsystem_pthread.dylib                0x185864d34 thread_start + 8

Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x0000000000000000   x1: 0x0000000000000000   x2: 0x0000000000000000   x3: 0x0000000000000000
    x4: 0x0000000000000010   x5: 0x0000000000003180   x6: 0x0000000000000000   x7: 0x0000000000000002
    x8: 0x4fce65bd93297579   x9: 0x4fce65bc7e42fa39  x10: 0x000060000bc27c57  x11: 0x0000000000000007
   x12: 0x0000000000000007  x13: 0x00006000034b9ed0  x14: 0x04000001ed6d6af1  x15: 0x00000001ed6d6af0
   x16: 0x0000000000000148  x17: 0x00000001f7dba4e8  x18: 0x0000000000000000  x19: 0x0000000000000006
   x20: 0x00000001ed6b8f40  x21: 0x0000000000000103  x22: 0x00000001ed6b9020  x23: 0x0000600001761bf0
   x24: 0x0000000000002000  x25: 0x000000000000002f  x26: 0x000000016b88c438  x27: 0x00000001f2867000
   x28: 0x0000000000000000   fp: 0x000000016b88c3b0   lr: 0x0000000185869c20
    sp: 0x000000016b88c390   pc: 0x00000001858315f0 cpsr: 0x40001000
   far: 0x0000000000000000  esr: 0x56000080  Address size fault

Binary Images:
       0x1052f4000 -        0x1052fffff libobjc-trampolines.dylib (*) <7d6ca1cb-c5e6-38b6-9618-2c580486fc6b> /usr/lib/libobjc-trampolines.dylib
       0x105370000 -        0x1053c3fff com.paddle.Paddle (4.4.3) <84546c84-ae4f-3aaf-9677-8ec2a3d9f072> /Applications/Fork.app/Contents/Frameworks/Paddle.framework/Versions/A/Paddle
       0x105454000 -        0x1054abfff org.sparkle-project.Sparkle (2.2.2) <bf7db5cd-507c-3ae0-a019-6fec80ed1143> /Applications/Fork.app/Contents/Frameworks/Sparkle.framework/Versions/B/Sparkle
       0x104570000 -        0x104c33fff com.DanPristupov.Fork (2.45.1) <9f9b15c1-65c7-3b68-86a3-faac11a7999f> /Applications/Fork.app/Contents/MacOS/Fork
       0x185828000 -        0x185862ffb libsystem_kernel.dylib (*) <71ff45b8-f14e-3666-9e96-6cf58315b91d> /usr/lib/system/libsystem_kernel.dylib
       0x185863000 -        0x18586ffff libsystem_pthread.dylib (*) <e03e8478-6f5c-3d21-a79a-58408f514000> /usr/lib/system/libsystem_pthread.dylib
       0x185700000 -        0x18577eff7 libsystem_c.dylib (*) <d30f1830-93d0-3d0b-8cba-9544e84bfd5b> /usr/lib/system/libsystem_c.dylib
       0x1858cb000 -        0x185da3fff com.apple.CoreFoundation (6.9) <55720ee0-d8c3-33a1-9854-8e61a6f44895> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
       0x185488000 -        0x1854d8e0b libobjc.A.dylib (*) <5c6386bd-f308-3370-bce9-63d1a89dab87> /usr/lib/libobjc.A.dylib
       0x18580c000 -        0x185827ffb libc++abi.dylib (*) <68e3eb36-b4ba-30e0-a240-31e942936d06> /usr/lib/libc++abi.dylib
       0x1856b5000 -        0x1856fcfff libdispatch.dylib (*) <1a1ce00a-89cd-36ba-9678-5038aedd0d8d> /usr/lib/system/libdispatch.dylib
       0x1900be000 -        0x190381fff com.apple.HIToolbox (2.1.1) <4166f6cb-b599-306c-8568-823bd29a74c3> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox
       0x18916d000 -        0x18a4abfff com.apple.AppKit (6.9) <7acbeef9-a453-3e4d-98ac-f9441d86e183> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
       0x1854d9000 -        0x185562507 dyld (*) <f635824e-318b-3f0c-842c-c369737f2b68> /usr/lib/dyld
               0x0 - 0xffffffffffffffff ??? (*) <00000000-0000-0000-0000-000000000000> ???
       0x186a20000 -        0x18767dfff com.apple.Foundation (6.9) <c6949f67-60f6-3735-b583-bf1e069a8a0b> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 21
    thread_create: 0
    thread_set_state: 1332

VM Region Summary:
ReadOnly portion of Libraries: Total=1.1G resident=0K(0%) swapped_out_or_unallocated=1.1G(100%)
Writable regions: Total=1.7G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=1.7G(100%)

                                VIRTUAL   REGION 
REGION TYPE                        SIZE    COUNT (non-coalesced) 
===========                     =======  ======= 
Accelerate framework               128K        1 
Activity Tracing                   256K        1 
CG image                          1200K       34 
ColorSync                          576K       27 
CoreAnimation                     21.4M      731 
CoreGraphics                        48K        3 
CoreGraphics (reserved)             16K        1         reserved VM address space (unallocated)
CoreImage                           32K        2 
CoreUI image data                 4208K       33 
Foundation                          16K        1 
Image IO                            32K        2 
Kernel Alloc Once                   32K        1 
MALLOC                             1.7G       79 
MALLOC guard page                  288K       18 
SQLite page cache                  256K        2 
STACK GUARD                       56.2M       14 
Stack                             14.9M       14 
VM_ALLOCATE                        848K       35 
__AUTH                            1672K      338 
__AUTH_CONST                      27.9M      541 
__CTF                               824        1 
__DATA                            12.9M      529 
__DATA_CONST                      28.1M      550 
__DATA_DIRTY                      1718K      197 
__FONT_DATA                          4K        1 
__LINKEDIT                       526.3M        5 
__OBJC_RO                         71.9M        1 
__OBJC_RW                         2200K        1 
__TEXT                           626.5M      569 
dyld private memory                272K        2 
libnetwork                         128K        8 
mapped file                      293.1M      616 
shared memory                      864K       14 
===========                     =======  ======= 
TOTAL                              3.3G     4372 
TOTAL, minus reserved VM space     3.3G     4372
DanPristupov commented 4 weeks ago

@honood Can you check if https://cdn.fork.dev/mac/Fork-2.45.2.dmg fixes the original problem?

honood commented 4 weeks ago

@honood Can you check if https://cdn.fork.dev/mac/Fork-2.45.2.dmg fixes the original problem?

Yes, it fixes. Thank you!

mrRay commented 3 weeks ago

On my end, 2.45.2 still uses the abnormal window size/position if you open a new tab via cmd-N or "File"->"New Window"

honood commented 3 weeks ago

On my end, 2.45.2 still uses the abnormal window size/position if you open a new tab via cmd-N or "File"->"New Window"

Me too🥴