search

fork-dev / Tracker

Bug and issue tracker for Fork for Mac
512 stars 12 forks source link

Fork 2.47 is slow at commiting changes #2223

Open Josscii opened 1 month ago

Josscii commented 1 month ago

The previous version is more fast than this one, is there someone facing the same issue?

enviroment: mac

DanPristupov commented 4 weeks ago

Fork now starts the default shell before committing to get its ENV.

  1. How long does it take now? The log at ~/Library/Logs/Fork.log must contain the duration in the line get PATH of ...
  2. Why does it take so long to start the shell on your computer? Normally it's very fast, for example it's about 20ms on my computer.
  3. You can disable this feature in Fork -> Preferences -> Git -> ENV PATH (select 'Parent process').
Josscii commented 4 weeks ago

it is a noticeable delay for commiting, as comparing to before updating. I’ll check the log latter.

My Mac is Mac mini m2 pro 32g, it should not has some performance issues.

Dan @.***>于2024年10月27日 周日16:28写道：

Fork now starts the default shell before committing to get its ENV.

  1. How long does it take now? The log at ~/Library/Logs/Fork.log must contain the duration in the line get PATH of ...
  2. Why does it take so long to start the shell on your computer? Normally it's very fast, for example it's about 20ms on my computer.
  3. You can disable this feature in Fork -> Preferences -> Git -> ENV PATH (select 'Parent process').

— Reply to this email directly, view it on GitHub https://github.com/fork-dev/Tracker/issues/2223#issuecomment-2439906109, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUUDQ2AGD3LVAOVLTKBXD3Z5SIZXAVCNFSM6AAAAABQVNKTKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZHEYDMMJQHE . You are receiving this because you authored the thread.Message ID: @.***>

bossm0n5t3r commented 4 weeks ago

Same here, I used to commit right away, but now I have a delay of about a second.

Josscii commented 4 weeks ago

Fork now starts the default shell before committing to get its ENV.

  1. How long does it take now? The log at ~/Library/Logs/Fork.log must contain the duration in the line get PATH of ...
  2. Why does it take so long to start the shell on your computer? Normally it's very fast, for example it's about 20ms on my computer.
  3. You can disable this feature in Fork -> Preferences -> Git -> ENV PATH (select 'Parent process').
  1. ⚠️[Stopwatch.swift:53] > 1061 get PATH of /bin/zsh
  2. don't know why it is slow to start shell, may be I install the powerlevel10k?
  3. after disable it, it still has the delay
DanPristupov commented 4 weeks ago

@Josscii

after disable it, it still has the delay

This is my bug. I'm releasing hotfix right now.

I'll investigate what is powerlevel10k a bit later

DanPristupov commented 4 weeks ago

@Josscii Can you try if you can disable this setting in 2.47.1, please?

https://cdn.fork.dev/mac/Fork-2.47.1.dmg

DanPristupov commented 4 weeks ago

1061 get PATH of /bin/zsh

That is a lot and most likely unreasonable.

don't know why it is slow to start shell, may be I install the powerlevel10k?

Check ~/.zshrc. Is there anything suspicious? May be try to comment out something.

Josscii commented 4 weeks ago

@Josscii Can you try if you can disable this setting in 2.47.1, please?

https://cdn.fork.dev/mac/Fork-2.47.1.dmg

This fix commiting delay, with parent process, thanks for your quick fix!

Josscii commented 4 weeks ago

1061 get PATH of /bin/zsh

That is a lot and most likely unreasonable.

don't know why it is slow to start shell, may be I install the powerlevel10k?

Check ~/.zshrc. Is there anything suspicious? May be try to comment out something.

Ok, I'll try figure this out, I have some configure for: powerlevel10k, conda, rbenv.

May be all of them are slow down it.

Nevertheless, it is ok to fix the slow issue by revert back to old parent process.

Thanks again.

elmolm commented 3 weeks ago

Same commit delay:

...
 ____  _____  ____  _  _      Fork 2.47.1
( ___)(  _  )(  _ \( )/ )     Git: system
 )__)  )(_)(  )   / )  (      Update Channel: develop
(__)  (_____)(_)\_)(_)\_)        https://fork.dev
...
⚠️[Stopwatch.swift:53] >  2628 get PATH of /bin/zsh
..
DanPristupov commented 3 weeks ago

@elmolm

Try to switch Fork to the 'Parent ENV' mode: Fork -> Preferences -> Git -> ENV PATH (select 'Parent process').

pdevito3 commented 3 weeks ago

i'm also seeing this, even after the hotfix, currently on v2.47.3 across multiple macs and OSX versions and seeing it

Try to switch Fork to the 'Parent ENV' mode: Fork -> Preferences -> Git -> ENV PATH (select 'Parent process').

this did seem to resolve but not great solution wise honestly. i'd expect a future update to automatically flip to this or to resolve it another way that doesn't require manual intervention if someone is bothered enough to hunt the github issues

DanPristupov commented 3 weeks ago

i'd expect a future update to automatically flip to this or to resolve it another way that doesn't require manual intervention if someone is bothered enough to hunt the github issues

Yes, we'll release the hotfix.