Use other color to show diff in Diff View

[Whirlwind]

In dark mode, the diff is red for delete lines and green for add lines, but I am a red and green color blindness. :(

[DanPristupov]

Can you provide any info how developers should solve such kind of problems?

[Whirlwind]

The SourceTree:

First, there is a + and -, this is very clear. Then the color is not red and green, and sourcetree app allow user custom the color.

[nebhale]

@DanPristupov I've not evaluated this directly, but the company I work for use Color Oracle during design work to simulate these scenarios. There are macOS native apps such as Sim Daltonism as well.

[DanPristupov]

@nebhale Sim Daltonism is a great application, thank you.

Here's how Fork looks. Seems to be confusing indeed.

I'm not ready to change whole application palette, but I can introduce a color-blind mode with more distinctive highlighting colors and additional - + signs. Local/Remote branch colors could be improved too.

Few questions to @Whirlwind :

1. What about GitHub palette? It should be quite bad, right?

   

2. Do you use any special appearance settings in macOS?

[Whirlwind]

What about GitHub palette? It should be quite bad, right?

There are multi ways to make a difference in diff view in the Github:

1. different color in line number column , it is clear.
2. different color for text background color, it is bad.
3. Highlight for changed text, it is clear.
4. + and - is very clear.

Do you use any special appearance settings in macOS?

No, I just use the dark style in the Fork.

[Whirlwind]

By the way, the color-blind have multi type, not just red and green.

[luong-komorebi]

My experiece in dark mode and when two changes sit next to each other is even much more challeging. I suggest that we

1. if possible, enable side by side diff view
2. Change the color scheme of the diff, or let users change it, customize it the way they want.

[DanPristupov]

In 1.0.73 we used better colors in the dark theme.

[laurentvaills]

I can see this issue is closed but still with 2.0.4 the difference of colors is not good for colorblind people in the diff view (only when it switches to dark theme):

[apff]

Even in the dark theme it's still hard to distinguish the colors for some red-green colorblind users.

An option to define custom highlight colors, like other users have suggested, would be really helpful and definitely solve this issue, not just for red-green but also for other types of colorblindness.

[DanPristupov]

In Fork 2.10 we added the option to show -+ marks near the change lines.

[laurentvaills]

Thanks for the -+ marks.

By the way, I just noticed that the background of the preview is not the same as the background of a real window.