search

fork-dev / TrackerWin

Bug and issue tracker for Fork for Windows
451 stars 10 forks source link

commit.template comments are not ignored #2142

Open frankbenoit opened 5 months ago

frankbenoit commented 5 months ago

If there is a config setting

[commit]
    template = .gitmessage

And the repo contains that .gitmessage:


# some explanations

The the text is shown in the commit dialog. In Git those lines starting with # are ignored, so as a user I do not need to delete those when creating a commit with git cli. However in Fork, those lines are all going into the commit message. I need to delete those manually.

frankbenoit commented 5 months ago

In addition: in git cli, the commit starting commit message must have been altered, otherwise the commit is aborted. In Fork, an empty message, the commit buttton is disabled. But it is enabled, if there is a message prefilled from gitmessage. IMO instead of this behavior, the commit button should be enabled as soon as the prefilled is changed from the prefilled.

DanPristupov commented 5 months ago

  1. Duplicate of https://github.com/fork-dev/TrackerWin/issues/203, which also has a link to more details.

  2. the commit button should be enabled as soon as the prefilled is changed from the prefilled.

It works this way already.

Check your commit message, may be it contains empty trailing spaces which get trimmed and cause mismatch. Or send me the commit template file and I'll tell what's wrong (support@fork.dev).