search

fork-dev / TrackerWin

Bug and issue tracker for Fork for Windows
450 stars 10 forks source link

`.mailmap` is not respected in the log panel #2182

Closed nagromc closed 2 months ago

nagromc commented 3 months ago

.mailmap seems to be respected in the commit details panel, but not in the log panel:

image

Example repository: https://github.com/nagromc/fork-mailmap-demo

Fork for Windows v1.95.0.0

DanPristupov commented 3 months ago

Thank you for the bug report. The problem happens because line ends with CLLF \r\n. If you change it to LF \n, in will work.

We'll fix this in 1.96

AFulgens commented 3 months ago

Just wanted to supply additional info: .mailmap is respected in the commit-view (bottom part) but not in the log view (main part). This behaviour is regardless whether the file has CRLF or LF, both exhibit the same behavior.

I am using .mailmap via the Git configuration value mailmap.file, the file is not directly in the repository.

This is a regression, in former versions .mailmap was respected in both views.

OS: Windows 22H2 (OS Build 19045.4170) Fork Version: 1.95.0.0

DanPristupov commented 3 months ago

I am using .mailmap via the Git configuration value mailmap.file, the file is not directly in the repository.

git config mailmap.file will not be supported for now.

AFulgens commented 3 months ago

git config mailmap.file will not be supported for now.

But... it was until recently? At least, it worked. And it still works, just not for the log panel.

nagromc commented 2 months ago

I can confirm the issue has been solved in v1.96.1.0.

I don’t know if the Git mailmap.file config thing should be in another thread, so I will let you close the issue.