search

fork-dev / TrackerWin

Bug and issue tracker for Fork for Windows
461 stars 10 forks source link

"External Diff" shortcut on added/removed files? #2358

Open ocornut opened 6 days ago

ocornut commented 6 days ago

When browsing a commit or branch I frequently use CTRL+D shortcut to open the diff tools to compare change in one file.

It doesn't work however if a file was added or removed:

image

Or course the removed or new file can be seen into Fork's own preview panes, but I like my diff tool, and it feels like the reviewing workflow would be more consistent if when pressing CTRL+D in this situation it would open my external diff tool with a temporary empty file on the other side.

Thank you for considering this small change :)

DanPristupov commented 1 day ago

Hi 👋. I made a test build. Can you try the improvement works as you expected?

https://cdn.fork.dev/prerelease/ForkWin-2.2.10.zip

Just extract .zip somewhere and run fork.exe.

ocornut commented 1 day ago

Thanks for the update. Unfortunately I did it, it updated my git instance and now Fork (old version or this) doesn't find a proper working git instance... my AppData\Local\Fork\gitInstance\ folder is empty. Trying to resolve now :)

ocornut commented 1 day ago

FYI I tried to reinstall last version from the website, it fixed it but I lost all my Fork settings. I then re-ran your version linked above, and External Diff worked as a expected. Thank you!

Losing my settings is a bit annoying but not the end of the world. It's however the first time it happens for me with Fork.