search

fork-maintainers / iceraven-browser

Iceraven Browser
4.66k stars 224 forks source link

[Bug] It is not possible to disable safebrowsing.- #145

Open ghost opened 4 years ago

ghost commented 4 years ago

Steps to reproduce

Open Iceraven Write about:config Change these strings: -browser.safebrowsing.malware.enabled from true to false -browser.safebrowsing.pishing.enabled from true to false Restart browser Those strings are true again

Expected behavior

Those strings would be false

Actual behavior

They changed as soon as you restart the app. Nevertheless, other strings remain changed without any problem but only those ones don't work

Device information

abhijitvalluri commented 4 years ago

I won't mark it as a bug as it seems to be the desired behaviour based on https://github.com/mozilla-mobile/fenix/issues/14163. In any case, it is very likely not trivial to fix and we likely do not have the time to do so (at least not me). So, if someone else wants to fix it go ahead!

ghost commented 4 years ago

I won't mark it as a bug as it seems to be the desired behaviour based on mozilla-mobile#14163. In any case, it is very likely not trivial to fix and we likely do not have the time to do so (at least not me). So, if someone else wants to fix it go ahead!

Could it be because of this? https://github.com/mozilla-mobile/android-components/blob/36c9570835a8f39bea1a04d185fc45b4a3503ec3/components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt#L507

interfect commented 4 years ago

I think https://github.com/mozilla-mobile/fenix/issues/15237#issuecomment-696132561 leads to the lines @Maji78 mentioned.

I think I'm going to change this from Wontfix to Help Wanted. We still might not be able to do this, but if it does send meaningful information and not just requests for parts of the block list to the list provider, that doesn't really jibe with our draft of a privacy policy. I think we want this on by default still, so we might have to revise the draft, but I also think we want it turn-off-able of we can manage it.

On Mobile we don't have the same problem with other malicious apps reaching into our settings and co figuri G us to be less secure, so it's not much of a danger to have a setting to turn this off.