search

fork-maintainers / iceraven-browser

Iceraven Browser
4.78k stars 222 forks source link

Option to disable the home button #437

Open Madis0 opened 2 years ago

Madis0 commented 2 years ago

What is the user problem or growth opportunity you want to see solved?

More space for the URL, less clutter in the UI.

How do you know that this problem exists today? Why is this important?

This is important because Mozilla added a home button, but not the option to disable it. Lack of an option makes it worse than Chromium alternatives and the desktop browsers (Firefox and others).

Who will benefit from it?

People who prefer minimalism.

See also: #53 for the opposite request.

interfect commented 2 years ago

Hmm. This does sound like a good thing to have. Any clue how this could be done in a way that won't give rise to a jillion merge conflicts?

Madis0 commented 2 years ago

An applied git patch perhaps, instead of rebasing on the change? I don't know how Fennec or its development actually works though.

seniordevel commented 1 year ago

This can easily be done by just hiding this button. It will not cause any problem.

Just a few lines of code would be needed, and some more to add a setting in about:config.

I would appreciate it.

interfect commented 1 year ago

If anyone wants to write a PR for this, that would be great. I'm not sure if about:config would be the right place for it, since that lives in Android Components, and since we've already added stuff to the normal settings screens successfully. Though with the monorepo merge maybe we'll end up building Android Components and thus able to patch it.

seniordevel commented 1 year ago

we've already added stuff to the normal settings screens successfully

Adding to the settings screen would be fine as well. I suggested about:config for just one reason: This is quickly done - whereas working with GUI is much more effort.

Maybe I'm wrong, but for me it seems the dev team here is small and their time is limited.

bt4ibwem8 commented 9 months ago

I can see we still cannot get rid of this button. Is it technically hard to add hide option in the settings?

interfect commented 9 months ago

Probably not. Would you like to work out how the address bar view stuff works and figure out what the setting would need to do to get it to be conditionally visible?

On Sunday, February 4, 2024, bt4ibwem8 @.***> wrote:

I can see we still cannot get rid of this button. Is it technically hard to add hide option in the settings?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

bt4ibwem8 commented 9 months ago

to add hide option in the settings?

correct. If it is not hard why it is not the option just to tick the checkbox in the settings? This button just clutter interface. Even Chrome does allow to hide it easily...

interfect commented 9 months ago

It's not that it would be hard to do, it's just that nobody has done it yet.

On Sun, Feb 4, 2024 at 10:46 AM bt4ibwem8 @.***> wrote:

to add hide option in the settings?

correct. If it is not hard why it is not the option just to tick the checkbox in the settings? This button just clutter interface. Even Chrome does allow to hide it easily...

— Reply to this email directly, view it on GitHub https://github.com/fork-maintainers/iceraven-browser/issues/437#issuecomment-1925800304, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFXTNQ5LDORBW5RK6YOZ53YR6UNJAVCNFSM5OEMYJIKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJSGU4DAMBTGA2A . You are receiving this because you commented.Message ID: @.***>