fork-maintainers / iceraven-browser

Iceraven Browser
4.67k stars 224 forks source link

Address bar in in site-specific browser (SSB) / app mode blocks part of page. #633

Open sonofevil opened 1 year ago

sonofevil commented 1 year ago

If you "install" (i.e. create a shortcut of), for example, Facebook on your home screen, Iceraven makes an SSB shortcut, which opens the site in SSB mode. SSB mode is overall pretty terrible, preventing access to most browser features and always displaying the address bar at the bottom, which unlike in normal mode doesn't hide when scrolling. As far as I can tell, this mode is identical to what happens when you open a site from within another app and it opens a restricted Iceraven web view.

Facebook doesn't understand this. It does not account for the address bar at all. It displays the page as if it wasn't there. This is bad because it prevents you from scrolling all the way to the bottom of comment sections. The last comment will be partly obscured.

Steps to reproduce:

Open Iceraven, go to facebook.com, open the menu, select "Install" or "Add to home screen" (the latter is shown while the page still loads, but the there is no difference in the resulting shortcut), go to home screen, click the shortcut, use the site.

Expected result:

The address bar either hides contextually, or the page geometry reflects the reduced viewport height.

Actual result:

The address bar remains always visible and blocks part of the page.

Possible solutions (ordered by desirability):

  1. Allow making non-SSB shortcuts of SSB sites.
  2. Auto-hide the address bar in SSB mode.
  3. Allow completely disabling SSB mode in the browser settings.
  4. Correctly apply stylesheet based on changed viewport geometry.
  5. Remove SSB mode entirely.

Further info:

Before they removed the SSB feature from desktop Firefox, there was an about:config setting called "browser.ssb.enabled". This doesn't exist in current Iceraven, but it really should.

System info:

Device: SM-A520F Android version: 11 Rom: LineageOS 18.1 a5y17let-userdebug 11 RQ3A.211001.001 Iceraven version: 2.6.1 (Build #2015955843)