search

forkachild / C-Simple-JSON-Parser

Extremely lightweight, easy-to-use & blazing fast JSON parsing library written in pure C
https://forkachild.github.io/C-Simple-JSON-Parser/
MIT License
45 stars 16 forks source link

Compiling with -pedantic and -Wextra leads to a lot of warnings #20

Closed stevemolloy closed 7 months ago

stevemolloy commented 7 months ago

When compiling with -pedantic and -Wextra I see a lot of warnings. Some of these are trivial (like the missing newline at the end of the .h file), but others seem more involved. For example, cast to union type is a GNU extension.

I'd like to get rid of the warnings so that my project compiles cleanly, but am unsure if there is something about this project that means that these will be hard to remove.

Any comments?

forkachild commented 7 months ago

@stevemolloy They are quite simple fixes I believe. Would you mind taking this up and raising a PR?

stevemolloy commented 7 months ago

I can take this. Give me a bit, and I will come back with a PR.

stevemolloy commented 7 months ago

Do you have any tests I could use? Except for example.c?

forkachild commented 7 months ago

There are no tests for this yet. I'll add them. Can you raise an issue for that?