forkdelta / tokenbase

A repository of ERC20 token information. Tokens listed are tradeable on https://forkdelta.github.io. We welcome contributions! 🎉
GNU General Public License v2.0
156 stars 329 forks source link

Formalize Listing Requirements #473

Closed JonathonDunford closed 4 years ago

JonathonDunford commented 6 years ago

It has become evident that we need to make our listing requirements more clear and robust in order to prevent the possibility of malicious tokens entering the system. We also need a formal document on GitHub that outlines the requirements for a proper token listing going forward.

Benefits: This lowers the likelihood of malicious tokens entering the system. This increases the openness of our procedure and opens it up for community feedback. This formalizes a procedure, so people understand the requirements of a proper listing request. This makes it easier on token developers to give us the proper information required for a submission.

Why the required data:


For Token Submissions

Anybody can request a token to be listed on ForkDelta, not just the token developers. However, the token submissions must strictly adhere to the following rules.

Absolutely required:

You must pay attention to the issue or pull request you post. We will post comments and make updates on it, some of which will need your attention.

Optional questions:

Strongly encouraged:

Strongly discouraged:

Absolutely not allowed:

Exceptions

There may be very rare cases where prominent ICOs do not adhere to our requirements, but have a large amount of users and are legitimate projects. We reserve the right to waive requirements in those rare cases.

tradedbytony commented 6 years ago

I'm a bit confused now. Over a week ago I asked about ERC223 and it seemed like they weren't gonna be listed anymore (issue #323) but now I see a "Make sure the token has proper ERC20 or ERC223 support." Does that mean ForkDelta has switched contracts so you guys can now list ERC223 tokens?

Some ERC223 contracts, such as the ones listed in issue #323 don't work, or at least didn't, with FD. Did that now change?

Thanks in advance.

Philipinho commented 6 years ago

I think we are good to go with these set of rules.

JonathonDunford commented 6 years ago

@tradedbytony ERC223 contracts that utilize proper whitelisting should work with the current contract.

However, we have a new contract in development (https://github.com/forkdelta/smart_contract) that will have full support for ERC223.

freeatnet commented 6 years ago

[retracted]

freeatnet commented 6 years ago

@JonathonDunford Could you please move the procedure to a separate issue? We should focus this issue on listing requirements and open it up to community discussion by posting it on our social media channels.

Plus, could you elaborate on what brings about this change proposal and why you think those requirements for token submissions make sense?

JonathonDunford commented 6 years ago

@freeatnet

Edited and moved: https://github.com/forkdelta/tokenbase/issues/495

Please take a look at both and see if there is anything I missed.

JonathonDunford commented 6 years ago

From https://github.com/forkdelta/tokenbase/issues/495


@tradedbytony :

If I may add, would it be possible to request for the token wanting to be listed to have their own website rather than a free website? For instance, there are some tokens such as https://forkdelta.github.io/#!/trade/EM-ETH which don't even own their own site (not to mention, that token doesn't even have properly set up links, such as Twitter, and use the default Wix ones).If they can't even afford to spend a few bucks for their own domains, perhaps they aren't worth listing. That's just my humble opinion.

@JonathonDunford :

@tradedbytony We have actually discussed that in Discord and it is a good point.The only reasoning against that that we can find is the fact that even our own website is hosted on a "free domain" and utilizes github.io for hosting. I'm not entirely sold either way, but I lean towards requiring a domain name as I think it lends more validity/credence to the project.Should there also be social media requirements?

tradedbytony commented 6 years ago

Considering many of these tokens manage to raise millions of dollars, having their own website shouldn't be an issue. Even small ICOs that raise a few hundred dollars have their own site.

In the case of FD, running off GH is actually a good thing because it shows the open resourcefulness of the project. In the case of a token/coin, having their own site shows commitment to the project not to mention the investors would want to check out the WHOIS and make sure the people behind it are transparent or not with that information.

Social media presence should be required, I believe. Shows the team is active and proactively engaging with their audience. Emails can take a long time to respond to. At the very least have a Twitter account. Telegram would be nice too. Having a blog in Medium would be ideal to push updates.

I've seen tokens, even tokens listed here on FD, with no email/twitter/TG/smoke signals or any kind of way to get in touch with the people behind it. I think the tokens with zero-interaction shouldn't even be considered. In the case of the example I listed earlier, that EM token, besides not having their own site they didn't even take the time to edit the default Wix template for social media and those social media links in there link to the default Wix ones.

tradedbytony commented 6 years ago

Also, if I'm getting this right, the template will be needing to change for when we open a new issue. For instance, right now when we open an issue it shows "A link to a third-party review or discussion of the token" which makes us choose between a third-party review OR bitcointalk, while this proposed change suggests we'll need them BOTH. Therefore, I suggest changing the default template to indicate this change.

And while on this topic, should ICOs such as https://electrify.asia which have raised over 30 million dollars and have a very high daily trade volume even on IDEX, not be listed on ForkDelta because they never bothered making an [ANN] thread on Bitcointalk? Should FD not list tokens like LOOM which don't have a whitepaper because devs don't believe in writing whitepapers (weird, I know) and yet they get listed straight to big exchanges like Kucoin? Or should there be exceptions for tokens which are already being traded on other exchanges (IDEX, HitBTC, Binance, etc), and what should be the scope of the exception for those tokens which never bother to make an [ANN] thread or some other aspect which violates the submission form in here? I've literally had over a dozen tokens which have a very high trading volume and/or raised tens/hundreds of millions of dollars during their ICO and/or are listed in the biggest exchanges around but I couldn't submit to ForkDelta because they don't quite fit in with the submission rules here. Just wondering what the exceptions should be and what would be the rules for said exceptions.

freeatnet commented 6 years ago

I think this is on the right track.

I hear @tradedbytony's concern about requiring BitcoinTalk threads. On the one hand, in my own experience of working on our listings, projects' BitcoinTalk threads weren't always a reliable source for community discussion and were susceptible to developers gaming the system via "leave a good BitcoinTalk comment" bounties. On the other hand, some projects might forgo a BitcoinTalk thread entirely because of their own priorities (e.g., they have an active marketing campaign otherwise and a BitcoinTalk thread is simply too low-yield). I propose replacing a BitcoinTalk thread requirement with the following:

  1. Require third-party review or discussion links of at least two kinds. This increases breadth of opinions, strengthens the case for the project's liveliness.
  2. To make sure the token issuer is reachable, require well-defined channels of communication with the token issuer to be published on the website: public social media is ideal, but I would also settle for an IM contact or email.

I'm a little concerned about requiring a whitepaper. Specifically, a number of projects that went through our listing process had whitepapers that talked at length about blockchain or Ethereum smart contracts (that's fine), but had little information about the project, vision, team, or milestones (that's no good). Instead of requiring a whitepaper, I would set requirements in terms of information we want to see published.

A few things we might want to explore further:

P.S. I'd like to drop the lowercase address requirement. It's a technical detail, which we might change based any time at our discretion.

Comment updated after submission

freeatnet commented 6 years ago

@JonathonDunford I think we should publish this discussion to our SM channels, what do you think?

Philipinho commented 6 years ago

Minimum token holders should be at least 30 because a contract creator can easily send tokens to 10 different wallets and then request for listing. If a token wants to be listed, they should make sure they have done an initial distribution before creating an issue.

tradedbytony commented 6 years ago

I agree with raising the minimum amount of token holders. It's way too easy to just raise it to 10 by oneself. Not saying one person couldn't do 30 by themselves but at least make them work for it, not to mention if there's only like 30-40 token holders and if the vast majority of those holders has nothing in their wallet, not even ETH, other than that one token it'd be pretty obvious something isn't right.

freeatnet commented 6 years ago

@Kryptoniq @tradedbytony Can you share what you're looking for when you want to introduce a minimum number of holders requirement?

JonathonDunford commented 6 years ago

The only reason why I don't think 30 token holders should be an absolute requirement is that it's very possible a company may choose to perform their ICO on ForkDelta in which case they would have 1 token holder.

JonathonDunford commented 6 years ago

I have updated the original comment to reflect commentary up to this point and will open this up to our social media channels shortly.

Bilibit commented 6 years ago

Sounds good and balance now for future listings.

walerikus commented 6 years ago

I think it would be great to put some marketing staff, like required amount of retwits to review a new application

rartokens commented 6 years ago

My 2 cents only. FD and the original ED are known for simple listing process and it has been the trademark of the exchange. If the requirements are getting tighter and it might end with no difference with the other exchanges (if that is the goal). My opinion is not to become too tight and not too lose.

on the other hand, ie Binance DEX, will be listing almost any coin with less control. https://www.bloomberg.com/news/articles/2018-03-13/crypto-exchange-binance-launches-decentralized-trading-network

I hope you will achieve balance in this effort.

remedcu commented 6 years ago

I think that sums up everything.

tund3r commented 6 years ago

Great job, if it's important that every token get a chance to get listed, having tokens like "FUCK" or "PUSSY" or whatever that have no meaning whatsaever, or tokens with Ethergold just to trick someone in buying a worthless token does not make any sense ... good job

JackAsparrow commented 6 years ago

How about allowing any coin to join Forkdelta without prior approval from the FD team. Instead maybe try putting a STAR symbol or something by all the officially verified tokens and putting a "Warning the token you are about to trade has not been verified by the ForkDelta team and may potentially be a scam or have other malicious intent"...????

Or can create a main page where all the tokens listed have been officially verified already and add a 2nd/separate page for unverified tokens. Then put up a BIG warning sign stating that said tokens on the 2nd page have not been verified or deemed trust worthy by the community/FD team and may be of malicious intent. It is not recommended that you trade any of these tokens. etc etc.

BTC-lite commented 6 years ago

HTTPS should be made mandatory only if an ICO is being carried out or user data is taken/stored. Otherwise it's useless.

Just my 2 cents.

freeatnet commented 6 years ago

@JackAsparrow you will still be able to trade any token by contract address, these are the requirements to get on that official list

freeatnet commented 6 years ago

@btc-lite Requiring HTTPS for all is in line with industry best practices: https://security.googleblog.com/2018/02/a-secure-web-is-here-to-stay.html?m=1

Philipinho commented 6 years ago

@rartokens it will be fatal if we just list any token without due diligence. It will negatively affect the ecosystem. We care about people's funds. ForkDelta don't want to be known as the exchange for "scams" and "frauds".

somidax commented 6 years ago

From our point of view, safety is non negotiable. so HTTPS should be a must for all in line with industry best standard ISO/IEC 27001 @BTC-lite @freeatnet

Philipinho commented 6 years ago

@JonathonDunford, @freeatnet Pertaining the proposed 30 minimum-holders; If a token wants to carry out their ICO on FD, it should be stated. Most tokens are "Airdrop tokens". Scam teams can end up selling worthless tokens to people on FD, without an actually future plan, then move to the next scam. What is the essence of 10 token holders for a token with over 100 million supply? It means 99.99% of the tokens belongs to the team.

JackAsparrow commented 6 years ago

@freeatnet Ah I see. Thanks for the clarification.

tradedbytony commented 6 years ago

One thing I'd like to add in here is a label for projects that want to get through the verification process first but not necessarily be listed right away. I've seen some projects this month filling out an official request to be listed but they ask to wait until a later date to actually be listed.

Perhaps adding an additional label like "Delay Listing" in addition to the "Information Complete" in these cases when the project wants to go through the confirmation process but they aren't yet ready for public listing because the tokens are locked until a later date.

Vasilii79 commented 5 years ago

The working platform that provides users with Bounty Stakes Trading service (first in the world) can not get listed since June 2018 on Forkdelta. Please look at this issue 1332: https://github.com/forkdelta/tokenbase/issues/1332

tokenbase-bot[bot] commented 4 years ago

This issue is stale because it has been open 21 days with no activity. We probably just don't have the bandwith to work on this. Sorry! Unless there is an update, it will be closed in 7 days.