search

forkgram / TelegramAndroid

Fork client of Telegram app for Android.
GNU General Public License v2.0
591 stars 30 forks source link

F-Droid build failed. #221

Closed linsui closed 3 months ago

linsui commented 6 months ago 
ERROR: Could not build app org.forkgram.messenger: Unexpected version/version code in output; APK: '10.5.0.0' / '422807',  Expected: '10.5.0.1' / '422817'

Could you please update the version name and code?

23rd commented 6 months ago

Sorry, I’m not sure what should I change. As far as I remember the first five digits from my version code should be taken + should be added the magic digit 8. So, the current latest version is 422819. The first five digits are 42281. With the magic digit result will be: 422818.

linsui commented 6 months ago

I don't know why the apk built by F-Droid has an old version name.

Gabr-F commented 5 months ago

I'm not really an Android developer, but it seems very likely that the check fails because the version was not really changed anywhere in the code..!

See https://github.com/forkgram/TelegramAndroid/compare/10.5.0.0..forkgram:TelegramAndroid:10.5.0.1?diff=unified&w= , these are all the differences between the 10.5.0.0 version and this last one.
No version change.

After quite a bit of effort I saw that the only thing changed in the last version was indeed the omission of the 968f10722 commit.

Gabr-F commented 5 months ago

Ok there was obviously also at least the patch "Fixed forward date from users with privacy." modified, from the 68d20a55f in the 10.5.0.0 version to the 57f667c49 of the 10.5.0.1.

This is extremely confusing

Gabr-F commented 5 months ago

(ok it looks like those were the only things changed)

23rd commented 3 months ago

@linsui please, can I ask you to change subdir: TMessagesProj_AppFork with subdir: TMessagesProj_App in the metadata yml file from the fdroid repository?

linsui commented 3 months ago

Done.