Open forkhroy opened 1 month ago
Splitter constructor is following a different pattern than Loader. It takes both conn and pref whereas Loader constructor takes only conn. Maybe we want to keep them consistent meaning both follow the same pattern.
// splitter public OracleDocumentSplitter(Connection conn, String pref) { this.conn = conn; this.pref = pref; }
// loader public OracleDocumentLoader(Connection conn) { this.conn = conn; }
Can we see same samples from other providers?
Any plural version for split?
https://github.com/langchain4j/langchain4j/blob/main/langchain4j/src/main/java/dev/langchain4j/data/document/splitter/DocumentByWordSplitter.java
protected abstract String[] split(String text)
https://github.com/langchain4j/langchain4j/tree/main/langchain4j/src/main/java/dev/langchain4j/data/document/splitter
https://github.com/langchain4j/langchain4j/blob/main/langchain4j/src/main/java/dev/langchain4j/data/document/splitter/HierarchicalDocumentSplitter.java
They provide these 2. We may also want to provide a Document version.
protected abstract String[] split(String text); public List split(Document document)
Splitter constructor is following a different pattern than Loader. It takes both conn and pref whereas Loader constructor takes only conn. Maybe we want to keep them consistent meaning both follow the same pattern.
// splitter public OracleDocumentSplitter(Connection conn, String pref) { this.conn = conn; this.pref = pref; }
// loader public OracleDocumentLoader(Connection conn) { this.conn = conn; }
Can we see same samples from other providers?
Any plural version for split?