search

forkineye / ESPixelStick

Firmware for the ESPixelStick
http://forkineye.com/
537 stars 171 forks source link

blank time can't be changed #685

Closed mxklb closed 11 months ago

mxklb commented 11 months ago

ESPixelStick Firmware Version latest CI build: ESPixelStick_Firmware-4.0-ci6755148587

Hardware Version espixelstick v3

Binary release or compiled yourself? CI build artifact

Operating System (and version) Linux 5.10.0-26-amd64 SMP Debian 5.10.197-1 (2023-09-29) x86_64 GNU/Linux

Web Browser (and version) Vivaldi 6.4.3160.34 stable

Access Point no

Describe the bug

The Blank Time (s) can't be changed. It always defaults to 5.

It's not possible to disable (0) or set it to anything else. This makes ESPixelStick kind of useless as a DMX Proxy, Input E1.31 -> Output DMX via MAX485. When not sending E1.31 constantly, DMX signal gets always blanked out after 5s :disappointed:

Expected behavior:

  1. Blank Time (s) = 0 disable blackout = constant/latest DMX signal output
  2. Blank Time (s) != 5 blackout happens after the configured time

Workaround: Send E1.31 continuously (= unnecessary/redundant E1.31 WiFI traffic)

See Screenshot for details:

Screenshot from 2023-11-05 17-09-06

Everything else on this page can be saved, only Blank Time (s) can't be changed.

MartinMueller2003 commented 11 months ago

Fixed device config values cant be changed #686

mxklb commented 11 months ago

@MartinMueller2003 how can I test your fix, to check if it provides expected Blank Time (s) behavior?

Should I just wait for it to be merged into mainline and then use the CI build artifact again?

MartinMueller2003 commented 11 months ago

My latest build is always found here: https://github.com/MartinMueller2003/ESPixelStick/releases/tag/dist

mxklb commented 11 months ago

Tested it: Sadly it's still not working as expected. Blank Time (s) always is 5s nevertheless what value is entered :disappointed:

@MartinMueller2003 can you please confirm this or how did you test your "fix" to be working as it should be?

mxklb commented 11 months ago

The link you provided still is version 4.0-ci6755148587, not containing your changes, that confused me.

Nevertheless it's already merged, so I tested against current mainline HEAD version 4.0-ci6771207306.

I can confirm your fix is working: Blank Time (s) can be disabled (0s) or changed to something != 5s.

So, this issue is done!, Thank you very much for your quick support, awesome!