search

forkineye / ESPixelStick

Firmware for the ESPixelStick
http://forkineye.com/
528 stars 169 forks source link

OLED support #729

Closed noman1228 closed 5 months ago

noman1228 commented 5 months ago

Just env lib and main loop.

MartinMueller2003 commented 5 months ago

I have reached my single review comment limit. Please undo all of the format changes. They make doing a review difficult. Please restore the missing files and restructure your oled support into an oled class. The class should be stand alone and technology independent. you can create a sub class for the specific oled you are implementing. Keen in mind that others may want to use other oled devices so your flavor should be a derived class from a pure virtual base class and the base class is used by the ino file.

MartinMueller2003 commented 5 months ago

And please use useful commit comments.

forkineye commented 5 months ago

Closing this one due to the numerous issues. Feel free to re-submit once they're corrected.

noman1228 commented 5 months ago

Re-Forking and instituting minimal changes with conditional includes. Told you it was hacky.... Thanks for your patience and hard work!