forknote / cryptonote-generator

Generate Cryptonote coin with 1 command
104 stars 211 forks source link

Wallet Extensions broken with Bytecoin latest version #30

Closed Haafingar closed 6 years ago

Haafingar commented 6 years ago

In walletd-spent-transfers-tracking-mode.json

Execute /home/dollarydoos/generator/extensions/walletd-spent-transfers-tracking-mode.json
- Making pre-tests in file /home/dollarydoos/generator/generated_files/tmp/src/Transfers/TransfersContainer.h
  + Pretest: marker exists - SpentOutputDescriptor(const TransactionOutputInformationIn& transactionInfo);
  + Pretest: marker exists - TransactionTypes::OutputType m_type;
  + Pretest: marker exists - uint64_t unlockTime;
  + Pretest: marker exists - SpentOutputDescriptor getSpentOutputDescriptor() const { return SpentOutputDescriptor(*this); }
  + Pretest: marker exists -   bool addTransaction(const TransactionBlockInfo& block, const ITransactionReader& tx, const std::vector<TransactionOutputInformationIn>& transfers);
  + Pretest: marker exists -   bool deleteUnconfirmedTransaction(const Crypto::Hash& transactionHash);
  + Pretest: marker exists -   bool markTransactionConfirmed(const TransactionBlockInfo& block, const Crypto::Hash& transactionHash, const std::vector<uint32_t>& globalIndices);
  + Pretest: marker exists -   > SpentTransfersMultiIndex;
  + Pretest: marker exists - bool addTransactionOutputs(const TransactionBlockInfo& block, const ITransactionReader& tx,
  + Pretest: marker exists - void copyToSpent(const TransactionBlockInfo& block, const ITransactionReader& tx, size_t inputIndex, const TransactionOutputInformationEx& output);
  + Pretest: marker exists - SpentTransfersMultiIndex m_spentTransfers;
ERROR: marker not found - SpentOutputDescriptor(uint64_t amount, uint32_t globalOutputIndex);

And in walletd-extension.jsonthe changes go through fine but the following error shows up in the build:

[ 48%] Building CXX object src/CMakeFiles/Wallet.dir/Wallet/WalletGreen.cpp.o
/home/dollarydoos/generator/generated_files/dollarydoos/src/Wallet/WalletGreen.cpp: In member function ‘virtual std::vector<CryptoNote::WalletOutput> CryptoNote::WalletGreen::getAddressOutputs(const string&) const’:
/home/dollarydoos/generator/generated_files/dollarydoos/src/Wallet/WalletGreen.cpp:1136:37: error: ‘const struct CryptoNote::TransactionOutputInformation’ has no member named ‘requiredSignatures’
     output.requiredSignatures = out.requiredSignatures;
                                     ^
src/CMakeFiles/Wallet.dir/build.make:86: recipe for target 'src/CMakeFiles/Wallet.dir/Wallet/WalletGreen.cpp.o' failed
make[2]: *** [src/CMakeFiles/Wallet.dir/Wallet/WalletGreen.cpp.o] Error 1
CMakeFiles/Makefile2:752: recipe for target 'src/CMakeFiles/Wallet.dir/all' failed

Thanks for all your work, fantastic tool! Keep at it

pmitchev commented 6 years ago

walletd-spent-transfers-tracking-mode.json is still in work, it's not working properly