Add mnemonic support extension to simplewallet

zpalmtree commented 6 years ago

Heya,

Recently we added mnemonics to Turtlecoin, and we thought you guys might like to have the option to add it as an extension. You can see the more readable version of the changes here - https://github.com/turtlecoin/turtlecoin/commit/347576be3281f3e42bb03de100439b9f31cfb5fe

I'm managed to get it to compile with some difficulty - it seemed that even without any changes the code didn't really want to compile on my gcc version, some hopefully this will work fine on your machines. I have tested out the mnemonic seeds and they export and import correctly.

Let me know if you want to clarify anything or need anything fixed up.

Thanks!

ghost commented 6 years ago

hello, nice addition, ty just to point out, mnemonics.json conflicts with bug-fixes.json both try to do the same change:

    {
      "action": "replace",
      "marker": "return sizeof(rs_comm) + pubs_count * sizeof(rs_comm().ab[0]);",
      "parameters": {
        "text": [
          "     return sizeof(rs_comm) + pubs_count * sizeof(ec_point_pair);"
        ]
      }
    }

pmitchev commented 6 years ago

Yes, bug fixes for the Core should be placed in bug-fixes.json

pmitchev commented 6 years ago

Fixed here: https://github.com/forknote/cryptonote-generator/commit/749c73146b0d0363802bfd32a85753d19b668b9a

zpalmtree commented 6 years ago

Thanks guys, sorry about that. I wasn't sure if I was doing something stupid on my end because it wasn't compiling without those fixes.

pmitchev commented 6 years ago

Thank you for your contribution. It will be included in the next Forknote version

forknote / cryptonote-generator

Add mnemonic support extension to simplewallet #65