forkwhilefork / bird-config-generator

10 stars 2 forks source link

refactor config-diff to handle multiple files #43

Closed forkwhilefork closed 3 years ago

forkwhilefork commented 3 years ago

as I said in #2: Adding another file we need to keep track of adds more complexity than I expected. Depending on our operating mode, we usually need to compare the current and proposed versions of a file, and act differently if they are the same or not. But now we have to do that process for at least two files (the config monolith and the cron file) and combine the results somehow. I think the file comparison logic needs to be refactored and maybe moved into a separate function.