forlooptanzania / ride-my-way

Car pooling app (of developers) by developers for developers in Tanzania
22 stars 6 forks source link

Weekly Support, 15th May 2019 #11

Closed joshuamabina closed 5 years ago

joshuamabina commented 5 years ago

Hi all!

Kindly drop in any question around the topics below:

  1. Git & GitHub
  2. Implementing the Front-End using HTML, CSS, and JavaScript.
  3. Implementing the Front-End using React.js

We will be joining a Q & A session with @BenMaruchu at 17:00hrs EAT. Please attend without fail to be able to unlock and unblock your world-class developer potential.

Join Zoom Meeting using https://andela.zoom.us/j/668566256

Abk47 commented 5 years ago

Should we open a new Git repository for the week 3 challenge or continue pushing our react codes in our existing repository?

joshuamabina commented 5 years ago

Should we open a new Git repository for the week 3 challenge or continue pushing our react codes in our existing repository?

Hello @Abk47

Thank you for this.

Proceed with the already created ride-my-way repository.

lupyana commented 5 years ago

Should we open a new Git repository for the week 3 challenge or continue pushing our react codes in our existing repository?

Hello @Abk47

Thank you for this.

Proceed with the already created ride-my-way repository.

I assume we create a new branch for react implementation and then push to that branch?

nelsonfrank commented 5 years ago

We create it in different branch, am i right?!..

joshuamabina commented 5 years ago

Should we open a new Git repository for the week 3 challenge or continue pushing our react codes in our existing repository?

Hello @Abk47 Thank you for this. Proceed with the already created ride-my-way repository.

I assume we create a new branch for react implementation and then push to that branch?

Very thoughtful of you @lupyana.

Yes. We will continue to use the github flow:

  1. develop --> feature
  2. Make a pull-request
  3. merge back to develop

Thank you very much for this.

I also recommend this GitHub issue as resource.

noelnoja commented 5 years ago

Got no question for today, still working on a weekly challenge but I want to appreciate you guys for awesome work that you are doing @forlooptanzania

BenMaruchu commented 5 years ago

Good starting point to learn react https://reactjs.org/docs/getting-started.html#thinking-in-react

lupyana commented 5 years ago

I have understood the recommendations on how to structure our commits. We can do various references to issues while committing our changes, that ties back to the issues for reference on what has been done.

Two questions:

  1. Is it good practice to use the closes issue tag when committing changes, or reserve that to pull requests
  2. After every feature should a PR be issued?
veemish commented 5 years ago

ben is it necessary every time we simple changes to make a commit about it?

BaharaJr commented 5 years ago

I would love to appreciate Ben and Joshy for awesome explains and of course Lupyana for raising some technical questions. You guys are doing some amazing work. Than you!

veemish commented 5 years ago

Thank you Ben for awesome explanation

BenMaruchu commented 5 years ago

I have understood the recommendations on how to structure our commits. We can do various references to issues while committing our changes, that ties back to the issues for reference on what has been done.

Two questions:

  1. Is it good practice to use the closes issue tag when committing changes, or reserve that to pull requests
  2. After every feature should a PR be issued?

It good to to close the issue/feature in PR since you can implement a single feature or fix a single bug using multiple commits so it better to close/fix that feature or issue using a PR

Also it is a good practice to have a feature branch and create a PR once you are done with it

joshuamabina commented 5 years ago

Setting the default branch

The default branch is considered the base branch in your repository, against which all pull requests and code commits are automatically made, unless you specify a different branch.

nelsonfrank commented 5 years ago

Any recommendation in the use of Stateful component and stateless component?!

joshuamabina commented 5 years ago

Any recommendation in the use of Stateful component and stateless component?!

ReactJS difference between stateful and stateless - StackOverflow

joshuamabina commented 5 years ago

Key Takeaways

Do commit early. Do commit often.

Git only takes full responsibility for your data when you commit. If you fail to commit and then do something poorly thought out, you can run into trouble. Additionally, having periodic checkpoints means that you can understand how you broke something.

Read more

Write meaningful commit messages.

... a well-crafted Git commit message is the best way to communicate context about a change to fellow developers (and indeed to their future selves).

Read more

Bundling with Webpack. It is important.

Given that:

  1. During development, it is good practice to split huge files into separate modules; because going through a huge file with code is extremely undesirable.

  2. During production, the client (browser) should be able to make one request to your server to load your scripts instead of making multiple requests to load your page.

Webpack, allows you to split your code into separate modules during development and then bundle them into one file for the client (browser) to consume, during production. This is highly favorable instead of making multiple requests to your server to load the page.

Read more

Editorconfig formats your code.

EditorConfig helps maintain consistent coding styles for multiple developers working on the same project across various editors and IDEs.

Read more

ESLint discovers problems. Better late, than never.

ESLint is a library used for linting JavaScript and JSX code.

Linting is the process of running a program that will analyse code for potential errors.

Read more

Transpiling with Babel.js. It is important.

Use next generation JavaScript, today.

Allows you to write ES6+ code and [transpile]() to compatible versions for the browser.

Babel.js - The compiler for next generation JavaScript.

Pull requests are Vital!

Pull requests play an important role during code reviews. They exist to suggest to the author or maintainer of the repository to, request to pull from my repository.

Read about pull requests.

Important Note Make pull request against the develop branch. As a safe measure, ensure that the develop branch is the default branch.

Learn about default branches here.

From HTML to React

Refer to the Challenge 1 instructions.