search

forlooptanzania / ride-my-way

Car pooling app (of developers) by developers for developers in Tanzania
22 stars 6 forks source link

How to Request for Code Review #35

Open joshuamabina opened 5 years ago

joshuamabina commented 5 years ago

Before You Start

Add our awesome code reviewers as collaborators to your repository. To do this:

  1. Go to Settings tab,
  2. Then, select, Collaborators and teams.
  3. Click, Add a collaborator. and input the usernames of our awesome code reviewers.

Code review or Pull-request Steps

  1. Create feature branch. It must originate from the develop branch and not the master branch.

  2. Do all your work on the feature branch.

  3. Do commit early and often, aim to make the first commit of your feature as soon as possible. Make them small and focused on completing a specific task. This way, it is easier to pick up on bugs very fast and will also help our code reviewers can give us much more insights and help about our code.

  4. Publish then perfect later. Once you are done with the feature (or some aspects of it), create a pull request and request for review. Remember to add all listed collaborators so that anyone available can begin reviewing your pull request as soon as possible.

In case of any question, please, feel free to drop in a comment or shoot all your mails to forlooptanzania@gmail.com