search

form3tech-oss / f1

A tool for writing load test scenarios in Golang with a powerful command line runner
Apache License 2.0
150 stars 29 forks source link

Verbose output is no longer well formatted (since v2.1.0) #280

Open sirockin opened 3 weeks ago

sirockin commented 3 weeks ago

When tests are run with the -v flag, results are no longer formatted as a table and there is no colouring.

This appears to have happened since the v2.1.0 re-write.

nvloff-f3 commented 3 weeks ago

Hi @sirockin ,

Yes, there has been a behavior change as part of #260

The aim of the change was to allow for the f1 output to be parsed by log collection systems with the introduction of structured logging.

As the verbose option would interweave structured logs (from the log file) and interactive messages, we found that difficult to handle for log parsers, so we made it that in case the verbose option was enabled all the output was structured logs. More details and rationale is available in the PR: #260

Can you describe your use case please? I'm happy to make adjustments to support, but I need a better understanding of that.

(in the meantime a workaround would be to use json format for the logs and use jq templating to achieve the exact formatting you're looking for)

sirockin commented 2 weeks ago

Hi @nvloff-f3 no specific use cases but we did find the previous -v output format useful and readable whereas the new one isn't.

Happy for you to mark it as wontfix.

nvloff-f3 commented 2 weeks ago

Alright, I think what's missing here is an option to force interactive mode. That, with a combination of providing a custom logger should restore the previous behavior.

We'll keep the defaults as they are, as we want to streamline f1 for unattended use, which I think should be the most common use case.

I'll see what that looks like, not sure exactly when I'll get to it, but I'll keep this open.