search

form8ion / remark-remove-greenkeeper-badge

remark plugin for removing a greenkeeper badge
https://npm.im/remark-remove-greenkeeper-badge
MIT License
1 stars 0 forks source link

remark@next (13) #4

Open wooorm opened 4 years ago

wooorm commented 4 years ago

Hi!

remark is switching to a new parser internally (remarkjs/remark#536). It seems this plugin should be fine, however, it would be good to check that in the future (there is 13.0.0-alpha.0 published now, and one or two more will come before the release)

P.S. it looks like you’re doing 5 complete walks of the tree here. It’s much faster to do one walk! See this guide on how to remove nodes with visit!

travi commented 4 years ago

Hi! Thanks for reaching out! I saw your tweet about the change the other day, and it sounds like it will be a nice improvement.

my integration tests for this plugin are passing after the change, so we should be good to go on this one. also, now that i've opted-in to the pre-releases, renovate should keep this project up to date with further pre-releases as you publish them.

i also appreciate the efficiency feedback. i'm definitely still learning proper use of remark, so tips are very welcome. my dev and testing process is very much in line with the "make it work (and prove it with tests), make it right, make it fast" approach. since i've mostly used this plugin for all of my repos that were using greenkeeper already, i might not find the time to make this particular one efficient. however, i have a handful of others that may be more worth the time. i've enjoyed using remark for the things i've had a chance to, so i hope to keep improving my use.

wooorm commented 4 years ago

Sweet, good to hear! And totes agree on make it work / right / fast!

Btw, add a remark-plugin keyword on github and plugins will magically display on the unifiedjs website!

travi commented 4 years ago

Btw, add a remark-plugin keyword on github and plugins will magically display on the unifiedjs website!

thanks for the reminder. i actually do include that tag in scaffolder plugin that i made for creating remark plugins, but missed going back to mark this one.

travi commented 4 years ago

actually, it looks like this repo already is tagged that way :)

wooorm commented 4 years ago

oh that was a reference to remark-inject-badges and remark-update-legacy-badge-markers, which don’t!