formaat-design / reshaped

Community repository for storing examples, reporting issues and tracking roadmap
https://reshaped.so
110 stars 3 forks source link

Question: Figma library #123

Closed mmailaender closed 1 year ago

mmailaender commented 1 year ago

This section confuses me every time 🙈 https://reshaped.so/content/docs/getting-started/figma/libraries#use-libraries

So should I only activate Dark OR Light library, or can I also activate BOTH?

mmailaender commented 1 year ago

After playing some minutes with it and activating Dark/Light and then keeping it completely off, I'm now completely confused why I overall need to activate it?

image

The reshaped plugin also works without having Dark OR/AND Light activated.

blvdmitry commented 1 year ago

The reason for that, is to make sure that when you're building custom components using our tokens – it also works correctly with theming. When you apply a theme in the plugin it finds all the styles with the token names found during them import and swaps the values to the picked theme. So in case you're applying a theme to the whole page but then some token values were used from another theme/mode – they will get reset to the theme you pick.

I'm updating the Figma docs today so going to take a look at this section as well

mmailaender commented 1 year ago

But what should happen, if I deactivate light library and activate dark library? Based on what you're saying, I would expect that it would update the assigned colors, or? (Similar to the theming plugin, but file wide) Because currently it seems for me, that it makes no difference to switch from Light to Dark library.

blvdmitry commented 1 year ago

Libraries you enable show in this popup when you pick which styles to apply to your custom frames. If you have both of them enabled – tokens from both library will appear in this menu:

image
mmailaender commented 1 year ago

Ahhhh - that's the missing puzzle piece - At the moment I'm activating both, e.g. Foreground/Neutral is not existing once, it's existing twice (Reshaped styles - Light v1.11 & Reshaped styles - Dark v1.11). And Figma is differentiating it. Intuitively I thought it's only existing once, and based on what I'm activating, it's overwriting the color code.

Thx for the explanation! 🙂