formaat-design / reshaped

Community repository for storing examples, reporting issues and tracking roadmap
https://reshaped.so
97 stars 3 forks source link

Feature Request: Option to make Breadcrumbs spreader non-interactive #227

Closed vladoyoung closed 3 months ago

vladoyoung commented 3 months ago

Is your feature request related to a problem? Please describe. Because of the way how I'm nesting things in my app, I'm experiencing a <button> within <button> nesting. That's not semantically correct and gets flagged as an error in the console.

Describe the solution you'd like Possibly either a prop that will be passed to the spreader button individually, or setting disabled={true} (or similar) to the whole breadcrumbs component, essentially making everything non-interactive whilst setting the element of the spreader to non-button. Similar to below:

Describe alternatives you've considered At the moment, (from the screenshot) I've set all the breadcrumbs to have pointer-events: none;. Which helps with making the whole thing non-interactive. However, this has nothing to do with the scope of the feature request. I'm only requesting for the option of the spreader not being a

blvdmitry commented 3 months ago

Great use case, will take a look for the next release

blvdmitry commented 3 months ago

Added a disableExpland flag in 2.10.3 which just renders an icon instead of the whole expand button. Docs will follow in the next minor release