formaat-design / reshaped

Community repository for storing examples, reporting issues and tracking roadmap
https://reshaped.so
97 stars 3 forks source link

Button component settings reset when updating from v2.6 -> v2.11 #243

Closed b-graves closed 2 months ago

b-graves commented 2 months ago
Screenshot 2024-04-15 at 16 43 38

v2.6

Screenshot 2024-04-15 at 16 43 58

v2.11

As you can see in this video, I am having some issues updating from v2.6 to 2.11. When I update all my buttons are reset to default settings. As you can see the badge and all other components I can see in the files I've updated work okay, but the button gets stuck.

Are you able to help me with this please? Thanks!

blvdmitry commented 2 months ago

Hey, this seems to be related to one of the previous versions where we have switched to using an atom inside the button to reduce the amount of total variants required since it was above the Figma performance recommendation. Seems like Figma didn't handle this change properly when swapping libraries while it worked as intended within the library 🥲

We'll try to look into any possible way for fixing this but I can't guarantee a good outcome here due to how limited control over the component instances is. Do you have a lot of buttons to migrate in your product?

b-graves commented 2 months ago

Hi, thanks for this. Yes we have a lot of buttons so this is slightly alarming! Any help on how to solve this would be much appreciated!

Is this the first time you've come across this issue? I would have expected it to happen to everyone migrating buttons?

Is it because we skipped the intermediate versions and are jumping directly from 2.6 to 2.11?

blvdmitry commented 2 months ago

We'll investigate this more trying migrating the button from different versions to 2.11. It might take some time so not sure if this is blocking anything on your side. We might also decide to revert the button composition changes and release a patch to make sure it doesn't break the migration path for you

b-graves commented 2 months ago

Thanks that would be great. It's not immediately blocking anything but we will need to migrate some time soon so we stay aligned with our dev team that is already updated to latest version

blvdmitry commented 2 months ago

Hey, so after trying a few approaches, probably the best way to mitigate this right now is for us to republish 2.11 with the old button structure. That should fix the library swapping issues. We don't plan to release any v2 minor versions right now and started working on v3 aiming for early July, slightly after the config. We'll re-apply the new structure again for v3 since it will contain other breaking changes too and we'll highlight all of them in our migration guidelines

blvdmitry commented 2 months ago

Updated the archive on the website. You can now find the old button structure file next to the original 2.11 release file in the Figma archive. Let me know if that works as expected for you 🙌

b-graves commented 2 months ago

Thanks for this! We are just not sure where to find the figma archive on the website?

Is it somewhere here?

Screenshot 2024-04-22 at 13 22 41
blvdmitry commented 2 months ago

It's inside the Download Figma library button, you'll find an additional file there with the old button variants setup

b-graves commented 2 months ago

Thanks! That works well, really appreciate your help with this. I don't really understand why this is only a problem for us? I would have expected it to be a problem for everyone migrating from old version? Going forwards will every new release contain this additional file and we just use that file instead of the main one?

blvdmitry commented 2 months ago

No, this happened to others as well but you were the first to report since not everyone updates the library so frequently or might have some of the components with custom implementation. We've also kept both option since there are teams that just got the library with the recent release.