search

formapro / JsFormValidatorBundle

The Javascript validation for Symfony 2, 3 and 4 forms
MIT License
128 stars 56 forks source link

Preserve original submit button #131

Open richard-ejem opened 7 years ago

richard-ejem commented 7 years ago

Currently, the button clicked to submit the form is not preserved and therefore not included in the request sent to server, because this package calls event.preventDefault, then, if the form is valid, sends form.submit(). This PR fixes the problem.

66Ton99 commented 3 years ago

Pleas look on the tests they are falling on you realization.

richard-ejem commented 3 years ago

Pleas look on the tests they are falling on you realization.

Thanks for the feedback, but honestly I did this 3 years ago, now I don't even do PHP much anymore and this PR is completely out of my interest now, so I'm not willing to spend any more time with it. I don't even know if the issue is still present in latest version. If you look at the test results, it seems the test setup is completely broken and it is obviously nothing that could be caused by the PR. It is very likely that if the PR is still valid, just rebasing on current master where tests work will fix it.