search

formapro / JsFormValidatorBundle

The Javascript validation for Symfony 2, 3 and 4 forms
MIT License
128 stars 56 forks source link

Symfony 4 compatibility attempt #150

Closed pesektomas closed 4 years ago

pesektomas commented 4 years ago

149 Attempt for symfony4 compatibility. Discussion is welcome.

66Ton99 commented 4 years ago

It's OK as for me, but need to restore build on https://travis-ci.org/formapro/JsFormValidatorBundle before I would be able to merge it. If you need some changes from my side please ask.

pesektomas commented 4 years ago

Ou, I have more problems with tests and build. But I will try to solved it.

pesektomas commented 4 years ago

Hello @66Ton99, we spent a lot of time with trying to fixed broken tests, but it is really hard. Some libraries already not exist (https://github.com/ptcong/php-image-uploader) and trying to run selenium is other story, ...

Finally, we tried write concept of new tests. We coverated javascript's constraints by unit tests and we writed new e2e test for checking complet functionality. For e2e test we used new project base in Tests folder builded on symfony 4.

I know that is not good way, but I really don't know how to fix broken old tests.

Could I ask you for your opinion on this solution?

66Ton99 commented 4 years ago

Looks great. Thanks!