Fix code examples in README

formatjs / dust-intl

Dust helpers for internationalization.

http://formatjs.io/dust/

Other

48 stars 11 forks source link

Fix code examples in README #28

Closed fhemberger closed 10 years ago

fhemberger commented 10 years ago

Change variable name in example from 'dateString' to 'dateStr' to match other occurrences
Dust helper parameters (like locale or currency identifiers) must be passed as strings. Numeric values like 40000.004 should be passed as strings as well, otherwise decimals with leading zeros get truncated (e.g. 40000.4).

yahoocla commented 10 years ago

CLA is valid!

fhemberger commented 10 years ago

(Note: Build failed because of #27)

fhemberger commented 10 years ago

Any chance to get this merged?

caridy commented 10 years ago

@clarle @juandopazo @drewfish can you guys revisit this?

fhemberger commented 10 years ago

Well, the review has been done a month ago. Can it be merged? It really just fixes typos and little inaccuracies in your README that will help people to get started using your helper.

drewfish commented 10 years ago

Sorry, yeah it looks good. +1

caridy commented 10 years ago

the failing unit test is probably an issue with intl after making the default month to be long instead of short to align with browsers, I can fix that.

caridy commented 10 years ago

dust-helper-intl@0.1.1

fhemberger commented 10 years ago

Thanks!