refactor to use ES6 and bundle up using transpiler

formatjs / dust-intl

Dust helpers for internationalization.

http://formatjs.io/dust/

Other

48 stars 11 forks source link

refactor to use ES6 and bundle up using transpiler #33

Closed caridy closed 10 years ago

caridy commented 10 years ago

continuation of https://github.com/yahoo/handlebars-helper-intl/pull/34

yahoocla commented 10 years ago

CLA is valid!

ericf commented 10 years ago

@drewfish do you want to look over this, since it's a major refactor?

ericf commented 10 years ago

I've made these changes here: https://github.com/caridy/dust-helper-intl/pull/2

ericf commented 10 years ago

@drewfish @caridy if you guys are good with this, I will merge and publish 1.0.0-rc-1 to npm.

drewfish commented 10 years ago

Looks good to me.

I'm curious though what the relationship is between this PR and caridy#2. It'd be a little easier to understand/review if all the changes were in one place.

ericf commented 10 years ago

It'd be a little easier to understand/review if all the changes were in one place.

@caridy originally created this PR, and I helped finish it off by opening a PR against his PR ;)