search

formatjs / dust-intl

Dust helpers for internationalization.
http://formatjs.io/dust/
Other
48 stars 11 forks source link

Run existing tests in the browser #43

Closed juandopazo closed 10 years ago

juandopazo commented 10 years ago

The existing tests were not written using Mocha's async support. This PR makes them async and uses expect.js to run them in the browser.

This is surfacing some issues in the browser which I yet don't understand. If someone can take a look at them, it'd be very much appreciated.

yahoocla commented 10 years ago

CLA is valid!

drewfish commented 10 years ago

+1

ericf commented 10 years ago

@juandopazo @drewfish should we merge this before 1.0?

juandopazo commented 10 years ago

If the this.locale change makes sense, then yes you can merge this before 1.0.

drewfish commented 10 years ago

+1 to latest version

ericf commented 10 years ago

Okay merging now, and I'll update the runtime deps and CLDR data, run a build, then watch for Travis and Sauce results.