formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Expose format helper methods for developers #14

Closed apipkin closed 10 years ago

ericf commented 10 years ago

What's the reasoning behind exposing these?

apipkin commented 10 years ago

The idea behind these format helper methods is to add the ability to take something like

{{intlDate NOW_DATE month="numeric" day="numeric" year="2-digit" hour="numeric" minute="numeric"}}

to something like

{{intlDate NOW_DATE format="medium" }}

This was the option rather than including only a few format options within the code itself. These methods have been approved for a while, but were never exposed to actually be used.

caridy commented 10 years ago

I'm ok with exposing them.

apipkin commented 10 years ago

If they aren't exposed, they should be removed from the the library as they wouldn't be useful to any one. As well as the calls to check if options.hash.format is stored anywhere.

caridy commented 10 years ago

+1 after docs landed.