search

formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Add tests for coverage #15

Closed apipkin closed 10 years ago

apipkin commented 10 years ago

Reached 90+% for branch coverage after UMD wrapper is considered.

Need to add in mockery in a new file to check for throws without intl and without intlMessageFormat

apipkin commented 10 years ago

ping @caridy @drewfish @ericf

ericf commented 10 years ago

Once the API is good to go (basically after we've integrated this into the full-intl) project, we can get branches to 100%, with excluding the UMD wrapper.

apipkin commented 10 years ago

@ericf That's what I've been working on this morning. The only thing not covered in this are the two initial throws when Intl and IntlMessageFormat are non existent. I'm looking now to get those added into the tests with mockery.

ericf commented 10 years ago

Not sure what we do with this now that we have an updated master.

ericf commented 10 years ago

Looks like too much has changed to make it practical to merge this… closing.

apipkin commented 10 years ago

@ericf agreed