search

formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

Add `registerDefault` to tackle setting defaults outside of handlebars contexts #16

Closed apipkin closed 10 years ago

drewfish commented 10 years ago

I like this approach better. I think this PR needs more tests to be sure that the results of registerDefault() are taken into consideration.

apipkin commented 10 years ago

@drewfish I first tried this out with #15 and it worked well. I just didn't want to "sneak" it into that PR without first at least getting an opinion on it.

apipkin commented 10 years ago

I also thought of setDefault instead of registerDefault since it's actually setting not registering

drewfish commented 10 years ago

Yeah I think setDefault is clearer.

apipkin commented 10 years ago

Closing and adding into PR #15