search

formatjs / handlebars-intl

Handlebars helpers for internationalization.
http://formatjs.io/handlebars/
Other
265 stars 28 forks source link

first attempt at (super-)UMD packaging #2

Closed drewfish closed 10 years ago

drewfish commented 10 years ago

The approach is to not try to auto-register in the Handlebars package, since we can't make any assumptions about where that library is located. (OK, as a shortcut we'll attempt to register in handlebars if it exists in the Handlebars global :smirk: )

There is one "test" (that doesn't work yet) run like this: node tests/helpers.js

drewfish commented 10 years ago

I based this off of the approach taken in the handlebars-form-helpers NPM package, which seemed to be the most mature.

BTW the instructions in the README.md are completely untested. They're based on the instructions for the handlebars-form-helpers package which are presumed to work. I'm assuming the general approach will work and that only a few details will need to be tweaked as we go.

caridy commented 10 years ago

great progress guys!

apipkin commented 10 years ago

I've been using this on my own umd-plus branch. There are a few typos, are you wanting to merge that back in here or just leave them corrected over there?

drewfish commented 10 years ago

@apipkin I'll take a look at your umd-plus branch and merge in changes.

apipkin commented 10 years ago

+1